Input of general nodal couplings from file

[kmokstad]

Downstream of OPM/IFEM#877.

Also some SIMFiniteDefEl refactor to prepare for separating out the 3D printing app.

[kmokstad]

jenkins build this with downstreams ifem=877 please

[Copilot]

Pull request overview

This PR extends the elasticity input format to support general nodal couplings defined in XML (inline) or loaded from an external file, and updates the “print max values” workflow to be driven from the input file (<print_max/>) rather than command-line flags. It also refactors parts of the finite-deformation application argument/material parsing in preparation for future app separation.

Changes:

• Add parsing/storage/application of general nodal couplings (<coupling ...> ... </coupling>) and hook them into preprocessing (MPC/self-interconnect).
• Add XML-driven max-value printing (<print_max/>) and adjust max-buffer initialization behavior/usage.
• Add a new linear regression test (“Snail”) exercising self-interconnection/coupling, and modernize some test geometry generator scripts.

Reviewed changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
Test/Nonlinear/PrintConcrete2D-p2.xinp	Adds <print_max/> to move max reporting into XML.
Test/Nonlinear/PrintConcrete2D-p2.reg	Updates baseline after removing -printMax CLI usage.
Test/Nonlinear/Necking-AxS-Fbar2.xinp	Adds <print_max/> to move max reporting into XML.
Test/Nonlinear/Necking-AxS-Fbar2.reg	Updates baseline after removing -printMax CLI usage.
Test/Linear/Snail-p1.xinp	New test input using <coupling> for self-interconnection.
Test/Linear/Snail-p1.reg	New regression baseline for the Snail coupling test.
Test/Linear/snail-p1.g2	New geometry for the Snail coupling test.
Test/Linear/snail_2D.py	Script to generate the Snail geometry using splipy.
Test/Linear/annulus3D.py	Removes old GoTools-based generator.
Test/Linear/annulus.py	Replaces GoTools generator with splipy-based generator (2D/3D).
NLargs.h	Refactors nonlinear args to derive from SIMargsBase.
NLargs.C	Updates option/XML parsing to delegate to SIMargsBase and use dim/adap.
main_NonLinEl.C	Adapts to refactored args (dim/adap) and XML preparse flow.
main_LinEl.C	Adds support for passing a .g2 directly by generating a temporary .xinp.
FiniteDeformation/SIMFiniteDefEl.h	Adds parseMaterial() hook for refactored material parsing.
FiniteDeformation/SIMFiniteDefEl.C	Refactors material parsing and adjusts history-dependent projection validation.
FiniteDeformation/PlasticMaterial.h	Marks plastic material as non-linear via isLinear().
FiniteDeformation/NeoHookeMaterial.h	Marks Neo-Hooke material as non-linear via isLinear().
Elasticity/SIMRigid.h	Expands rigid handler into rigid + general nodal coupling handler and adds storage.
Elasticity/SIMRigid.C	Implements coupling parsing (inline/file) and applying couplings/self-interconnect.
Elasticity/SIMElasticity.C	Wires coupling parsing into XML parsing and enables <print_max/> handling.
Elasticity/NonlinearDriver.C	Adjusts max-value initialization flow using new initMaxVals() return type.
Elasticity/MaterialBase.h	Introduces Material::isLinear() API.
Elasticity/Elasticity.h	Changes initMaxVals() signature to return bool.
Elasticity/Elasticity.C	Implements new initMaxVals() behavior/return value.
CMakeLists.txt	Adds the new Snail regression test to CTest.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 26 out of 26 changed files in this pull request and generated 6 comments.