Move oil volume result to experimental features and demote ROFF logs to debug

Gate the derived oil volume cell result behind the new 'oil-volume-result'
experimental feature instead of RiaApplication::enableDevelopmentFeatures().

In the ROFF file reader, drop the enableDevelopmentFeatures() gates around the
grid dimension, timing and array diagnostics and log them at debug level instead,
so the output is available without RESINSIGHT_DEVEL but stays quiet in normal
runs.

Author: kriben

ApplicationLibCode/Application/RiaExperimentalFeatures.cpp

@@ -33,6 +33,7 @@ const std::vector<RiaExperimentalFeatures::Feature>& RiaExperimentalFeatures::av
         { "osdu-well-logs", "OSDU Well Logs", "Enable import of well logs from OSDU." },
         { "undo-redo-view", "Undo/Redo View", "Show the command undo/redo history view." },
         { "export-dock-layout", "Export Dock Layout", "Add a window menu action to export the dock layout to the clipboard." },
+        { "oil-volume-result", "Oil Volume Result", "Compute the derived oil volume cell result." },
     };
 
     return features;

ApplicationLibCode/FileInterface/RifRoffFileTools.cpp

@@ -149,12 +149,9 @@ bool RifRoffFileTools::openGridFile( const QString& fileName, RigEclipseCaseData
         float yScale = getFloat( values, "scale.yscale" );
         float zScale = getFloat( values, "scale.zscale" );
 
-        if ( RiaApplication::enableDevelopmentFeatures() )
-        {
-            RiaLogging::info( std::format( "Grid dimensions: {} {} {}", nx, ny, nz ) );
-            RiaLogging::info( std::format( "Offset: {} {} {}", xOffset, yOffset, zOffset ) );
-            RiaLogging::info( std::format( "Scale: {} {} {}", xScale, yScale, zScale ) );
-        }
+        RiaLogging::debug( std::format( "Grid dimensions: {} {} {}", nx, ny, nz ) );
+        RiaLogging::debug( std::format( "Offset: {} {} {}", xOffset, yOffset, zOffset ) );
+        RiaLogging::debug( std::format( "Scale: {} {} {}", xScale, yScale, zScale ) );
 
         std::vector<float> cornerLines = reader.getFloatArray( "cornerLines" + roff::Parser::postFixData() );
         std::vector<float> zValues     = reader.getFloatArray( "zvalues" + roff::Parser::postFixData() );
@@ -259,22 +256,19 @@ bool RifRoffFileTools::openGridFile( const QString& fileName, RigEclipseCaseData
         activeCellInfo->computeDerivedData();
         fractureActiveCellInfo->computeDerivedData();
 
-        if ( RiaApplication::enableDevelopmentFeatures() )
-        {
-            auto gridConstructionDone = high_resolution_clock::now();
+        auto gridConstructionDone = high_resolution_clock::now();
 
-            auto tokenizeDuration = duration_cast<milliseconds>( tokenizeDone - totalStart );
-            RiaLogging::info( std::format( "Tokenizing: {} ms", tokenizeDuration.count() ) );
+        auto tokenizeDuration = duration_cast<milliseconds>( tokenizeDone - totalStart );
+        RiaLogging::debug( std::format( "Tokenizing: {} ms", tokenizeDuration.count() ) );
 
-            auto parsingDuration = duration_cast<milliseconds>( parsingDone - tokenizeDone );
-            RiaLogging::info( std::format( "Parsing: {} ms", parsingDuration.count() ) );
+        auto parsingDuration = duration_cast<milliseconds>( parsingDone - tokenizeDone );
+        RiaLogging::debug( std::format( "Parsing: {} ms", parsingDuration.count() ) );
 
-            auto gridConstructionDuration = duration_cast<milliseconds>( gridConstructionDone - parsingDone );
-            RiaLogging::info( std::format( "Grid Construction: {} ms", gridConstructionDuration.count() ) );
+        auto gridConstructionDuration = duration_cast<milliseconds>( gridConstructionDone - parsingDone );
+        RiaLogging::debug( std::format( "Grid Construction: {} ms", gridConstructionDuration.count() ) );
 
-            auto totalDuration = duration_cast<milliseconds>( gridConstructionDone - totalStart );
-            RiaLogging::info( std::format( "Total: {} ms", totalDuration.count() ) );
-        }
+        auto totalDuration = duration_cast<milliseconds>( gridConstructionDone - totalStart );
+        RiaLogging::debug( std::format( "Total: {} ms", totalDuration.count() ) );
     }
     catch ( std::runtime_error& err )
     {
@@ -541,11 +535,8 @@ std::pair<bool, std::map<QString, QString>> RifRoffFileTools::createInputPropert
         for ( auto [keyword, kind] : arrayTypes )
         {
             size_t keywordLength = reader.getArrayLength( keyword );
-            if ( RiaApplication::enableDevelopmentFeatures() )
-            {
-                RiaLogging::info(
-                    std::format( "Array found: '{}'. Type: {} with size: {}.", keyword, roff::Token::kindToString( kind ), keywordLength ) );
-            }
+            RiaLogging::debug(
+                std::format( "Array found: '{}'. Type: {} with size: {}.", keyword, roff::Token::kindToString( kind ), keywordLength ) );
 
             QString keywordUpperCase = QString::fromStdString( keyword ).toUpper();
 

ApplicationLibCode/ReservoirDataModel/RigCaseCellResultsData.cpp

@@ -20,11 +20,11 @@
 
 #include "RigCaseCellResultsData.h"
 
-#include "RiaApplication.h"
 #include "RiaDefines.h"
 #include "RiaEclipseUnitTools.h"
 #include "RiaLogging.h"
 #include "RiaPreferencesGrid.h"
+#include "RiaPreferencesSystem.h"
 #include "RiaResultNames.h"
 
 #include "RifReaderEclipseOutput.h"
@@ -1016,7 +1016,7 @@ void RigCaseCellResultsData::createPlaceholderResultEntries()
     }
 
     // Oil Volume
-    if ( RiaApplication::enableDevelopmentFeatures() )
+    if ( RiaPreferencesSystem::current()->isFeatureEnabled( "oil-volume-result" ) )
     {
         if ( hasResultEntry( RigEclipseResultAddress( RiaDefines::ResultCatType::DYNAMIC_NATIVE, RiaResultNames::soil() ) ) )
         {