Refresh filter tree facade when cell/property filters change#14073
Draft
magnesj wants to merge 3 commits into
Draft
Refresh filter tree facade when cell/property filters change#14073magnesj wants to merge 3 commits into
magnesj wants to merge 3 commits into
Conversation
…erty filter changes Add public RimEclipseView::filterInViewCollection() accessor and call updateConnectedEditors() on it whenever an Eclipse property filter is added, inserted, removed (undo), linked to the cell result, or created by the well allocation flow. Also switch RicPasteCellFiltersFeature to the shared selectAndRefreshFilterTree helper.
Member
Author
|
@kriben Discovered several update issues after the change from individual filter collections to one single filter collection. Not sure how to fix this best, maybe forward This draft PR does not look good. Created an issue to track this bug: #14074 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RimFilterInViewCollectionfacade.RimEclipseView::filterInViewCollection()accessor (was only the private field on dev).addPropertyFilter), inserted into a combined filter, inserted at index, removed via undo, linked to the cell result, or created by the well-allocation "Show Contributing Wells" flow.RicPasteCellFiltersFeaturenow uses the sharedRicCellFilterFeatureTools::selectAndRefreshFilterTreehelper instead of duplicating the select-and-refresh logic.