#14083 Well Disks: Keep disk radius stable when toggling well visibility#14085
Open
kriben wants to merge 3 commits into
Open
#14083 Well Disks: Keep disk radius stable when toggling well visibility#14085kriben wants to merge 3 commits into
kriben wants to merge 3 commits into
Conversation
Normalize disk radius over all wells instead of only the currently visible ones. Computing the min/max range over visible wells only made one well's disk radius depend on whether unrelated wells were filtered out, so toggling a range filter on one well changed another well's disk. Fixes #14083.
On project reload the simulation well disks were not drawn until the user toggled the Simulation Wells visibility. Two load-ordering issues caused this: scaleWellDisks() ran before synchronizeWellsWithResults() had populated the wells list, so it iterated an empty collection. It also bailed out early on the transient m_showWellDisks aggregate (disableIO), which is only synced from the restored per-well states when the property panel is built. Move scaleWellDisks() after synchronizeWellsWithResults(), and sync the visibility checkbox state at the start of scaleWellDisks() so the disks are scaled and marked valid before the first display-model build.
Well disks are flat, zero-thickness discs drawn at a fixed elevation above each well head. When the disks of different wells overlap horizontally they end up coplanar at the same depth and z-fight. Offset each disk along Z by a small per-well amount derived from the stable resultWellIndex(), scaled by arrowLength so the spacing tracks the disk scale and view zoom. Coincident disks fan out into a readable vertical stack instead of fighting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normalize disk radius over all wells instead of only the currently visible ones. Computing the min/max range over visible wells only made one well's disk radius depend on whether unrelated wells were filtered out, so toggling a range filter on one well changed another well's disk.
Fixes #14083.