Guard Against Missing Phases When Extracting Curves#116
Draft
bska wants to merge 1 commit into
Draft
Conversation
This commit adds certain checks for active phases before attempting to construct curve interpolants and retrieving curve points from those interpolants. Notably, we make sure that we don't return water-related curves (e.g, krw, krow, pcow) in a gas/oil system, nor gas-related curves in an oil/water system. Finally, add initial support for gas/water systems. The Pcgw capillary pressure curve is, however, not fully finalised.
Member
Author
|
I'm creating this PR in draft mode because I need to add unit tests before it's ready to go. |
magnesj
added a commit
to OPM/ResInsight
that referenced
this pull request
Mar 9, 2026
magnesj
added a commit
to OPM/ResInsight
that referenced
this pull request
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds certain checks for active phases before attempting to construct curve interpolants and retrieving curve points from those interpolants. Notably, we make sure that we don't return water-related curves (e.g, krw, krow, pcow) in a gas/oil system, nor gas-related curves in an oil/water system.
Finally, add initial support for gas/water systems. The Pcgw capillary pressure curve is, however, not fully finalised.