Skip to content

Updating ECLGraph::haveConnData so that 1D and 2D cases are handled c…#21

Open
vkip wants to merge 1 commit into
OPM:masterfrom
vkip:master
Open

Updating ECLGraph::haveConnData so that 1D and 2D cases are handled c…#21
vkip wants to merge 1 commit into
OPM:masterfrom
vkip:master

Conversation

@vkip

@vkip vkip commented Nov 14, 2016

Copy link
Copy Markdown
Member

…orrectly (in these cases missing dimension arrays are not present in the data file).

…orrectly (in these cases missing dimension arrays are not present in the data file).
@atgeirr

atgeirr commented Nov 14, 2016

Copy link
Copy Markdown
Member

Sounds like a useful and important fix, thanks! Assigning @bska to check and merge this (if OK). There are some annoying tab-vs-spaces issues (we try to go with spaces exclusively), but we can fix that.

@bska

bska commented Nov 14, 2016

Copy link
Copy Markdown
Member

This will return true if any of the (I,J,K) vectors are present. We need it to return true only if all the (relevant) vectors are present.

@atgeirr

atgeirr commented Nov 14, 2016

Copy link
Copy Markdown
Member

I am a little confused now: if you are running a 1d case, it will actually be represented as a 3d case, but with a string of cells in only one direction (for example a 1 x 1 x 10 grid), correct? If so, would not the simulator still output fluxes in the I+ and J+ directions (that would be zero)?

Do you have a case that shows this, that causes the current code to fail?

@atgeirr

atgeirr commented Dec 27, 2017

Copy link
Copy Markdown
Member

Is this something we should resurrect, or just close @vkip?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants