Heavy optimize CPU and memory usages

Introduces reusable lists and maps for batch processing in Combat.java to reduce allocations, improves config value loading and reloads, and adds config reload support to GlowManager. Refactors CrystalManager to avoid unnecessary allocations. ChatUtil now short-circuits plain messages for performance. Removes unused throttling logic from SchedulerUtil. EntityDamageByEntityListener now caches references for efficiency.

Author: OPmasterLEO

src/main/java/net/opmasterleo/combat/Combat.java

@@ -26,6 +26,7 @@
 import net.opmasterleo.combat.Combat;
 import net.opmasterleo.combat.manager.SuperVanishManager;
 import net.opmasterleo.combat.util.SchedulerUtil;
+import net.opmasterleo.combat.util.WorldGuardUtil;
 
 public final class EntityDamageByEntityListener implements PacketListener, Listener {
     private static final long ATTACK_TIMEOUT = 5000;
@@ -35,12 +36,18 @@ public final class EntityDamageByEntityListener implements PacketListener, Liste
     private final Map<UUID, Long> attackTimestamps = new ConcurrentHashMap<>();
     private final Combat combatInstance = Combat.getInstance();
     private boolean initialized = false;
+    private NewbieProtectionListener protectionListener;
+    private WorldGuardUtil worldGuardUtil;
+    private SuperVanishManager vanishManager;
 
     public EntityDamageByEntityListener() {
     }
 
     public void initialize() {
         if (initialized) return;
+        protectionListener = combatInstance.getNewbieProtectionListener();
+        worldGuardUtil = combatInstance.getWorldGuardUtil();
+        vanishManager = combatInstance.getSuperVanishManager();
 
         combatInstance.getServer().getPluginManager().registerEvents(this, combatInstance);
         if (combatInstance.isPacketEventsAvailable()) {
@@ -113,19 +120,17 @@ private boolean isCreativeOrSpectator(Player player) {
     }
 
     private boolean isProtectedInteraction(Player attacker, Player victim) {
-        NewbieProtectionListener protectionListener = combatInstance.getNewbieProtectionListener();
         if (protectionListener != null) {
             boolean attackerProtected = protectionListener.isActuallyProtected(attacker);
             boolean victimProtected = protectionListener.isActuallyProtected(victim);
             if (attackerProtected != victimProtected) return true;
         }
 
-        if (combatInstance.getWorldGuardUtil() != null && combatInstance.getWorldGuardUtil().isPvpDenied(victim.getLocation())) {
+        if (worldGuardUtil != null && worldGuardUtil.isPvpDenied(victim.getLocation())) {
             return true;
         }
 
-        SuperVanishManager vanish = combatInstance.getSuperVanishManager();
-        return vanish != null && (vanish.isVanished(attacker) || vanish.isVanished(victim));
+        return vanishManager != null && (vanishManager.isVanished(attacker) || vanishManager.isVanished(victim));
     }
 
     private boolean isSelfAttack(Player attacker, Player victim) {

src/main/java/net/opmasterleo/combat/listener/EntityDamageByEntityListener.java

@@ -61,8 +61,16 @@ public void setPlacer(Entity crystal, Player placer) {
         UUID crystalId = crystal.getUniqueId();
         UUID placerId = placer.getUniqueId();
 
-        crystalData.computeIfAbsent(crystalId, k -> new CrystalData(placerId, crystal.getWorld().getName()));
-        playerCrystals.computeIfAbsent(placerId, k -> ConcurrentHashMap.newKeySet()).add(crystalId);
+        crystalData.putIfAbsent(crystalId, new CrystalData(placerId, crystal.getWorld().getName()));
+        Set<UUID> crystals = playerCrystals.get(placerId);
+        if (crystals == null) {
+            crystals = ConcurrentHashMap.newKeySet();
+            Set<UUID> existing = playerCrystals.putIfAbsent(placerId, crystals);
+            if (existing != null) {
+                crystals = existing;
+            }
+        }
+        crystals.add(crystalId);
 
         if (System.currentTimeMillis() - lastCleanup > CLEANUP_INTERVAL) {
             plugin.getCombatWorkerPool().execute(this::cleanupExpiredEntries);

src/main/java/net/opmasterleo/combat/manager/CrystalManager.java

@@ -31,6 +31,7 @@ public class GlowManager {
     private static final long PACKET_THROTTLE_MS = 50;
     private static final int CLEANUP_THRESHOLD = 100;
     private volatile boolean enabled = true;
+    private volatile boolean glowingConfigEnabled = true;
 
     private static class GlowState {
         final boolean isGlowing;
@@ -44,6 +45,7 @@ private static class GlowState {
 
     public void initialize(Combat plugin) {
         this.plugin = plugin;
+        this.glowingConfigEnabled = plugin.getConfig().getBoolean("General.CombatTagGlowing", false);
         schedulePeriodicCleanup();
         schedulePeriodicSync();
     }
@@ -52,6 +54,10 @@ public void setEnabled(boolean enabled) {
         this.enabled = enabled;
     }
 
+    public void reloadConfig() {
+        this.glowingConfigEnabled = plugin.getConfig().getBoolean("General.CombatTagGlowing", false);
+    }
+    
     private void schedulePeriodicCleanup() {
         SchedulerUtil.runTaskTimerAsync(plugin, () -> {
             long now = System.currentTimeMillis();
@@ -83,7 +89,7 @@ private void schedulePeriodicCleanup() {
     private void schedulePeriodicSync() {
         SchedulerUtil.runTaskTimerAsync(plugin, () -> {
             try {
-                if (!enabled || !plugin.getConfig().getBoolean("General.CombatTagGlowing", false)) {
+                if (!enabled || !glowingConfigEnabled) {
                     return;
                 }
                 List<Player> playersToSync = new ArrayList<>();
@@ -148,7 +154,7 @@ public void setGlowing(Player player, boolean glowing, UUID opponentId) {
             return;
         }
 
-        if (glowing && (!enabled || !plugin.getConfig().getBoolean("General.CombatTagGlowing", false))) {
+        if (glowing && (!enabled || !glowingConfigEnabled)) {
             glowingPlayers.remove(playerId);
             removeGlowEffect(player);
             return;
@@ -165,7 +171,7 @@ public void setGlowing(Player player, boolean glowing, UUID opponentId) {
 
     public boolean syncWithCombat(Player player) {
         if (player == null) return false;
-        if (!enabled || !plugin.getConfig().getBoolean("General.CombatTagGlowing", false)) {
+        if (!enabled || !glowingConfigEnabled) {
             GlowState current = glowingPlayers.get(player.getUniqueId());
             if (current != null && current.isGlowing) {
                 setGlowing(player, false, null);
@@ -238,7 +244,7 @@ public void cleanup() {
 
     private void applyGlowEffect(Player player, UUID opponentId) {
         if (player == null) return;
-        if (!enabled || !plugin.getConfig().getBoolean("General.CombatTagGlowing", false)) return;
+        if (!enabled || !glowingConfigEnabled) return;
 
         try {
             setGlowingWithPacketEvents(player, true, opponentId);
@@ -314,7 +320,7 @@ private void removeGlowEffect(Player player) {
 
     private void setGlowingWithPacketEvents(Player player, boolean glowing, UUID opponentId) {
         if (player == null) return;
-        if (!enabled || !plugin.getConfig().getBoolean("General.CombatTagGlowing", false)) {
+        if (!enabled || !glowingConfigEnabled) {
             if (glowing) return;
         }
 

src/main/java/net/opmasterleo/combat/manager/GlowManager.java

@@ -1,5 +1,8 @@
 package net.opmasterleo.combat.util;
 
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
 import net.kyori.adventure.text.Component;
 import net.kyori.adventure.text.TextComponent;
 import net.kyori.adventure.text.format.NamedTextColor;
@@ -9,9 +12,6 @@
 import net.kyori.adventure.text.minimessage.tag.standard.StandardTags;
 import net.kyori.adventure.text.serializer.legacy.LegacyComponentSerializer;
 
-import java.util.regex.Matcher;
-import java.util.regex.Pattern;
-
 public class ChatUtil {
     private static final Pattern HEX_COLOR_PATTERN = Pattern.compile("&#([A-Fa-f0-9]{6})");
 
@@ -29,6 +29,10 @@ public static Component parse(String message) {
             return Component.empty();
         }
 
+        if (message.indexOf('&') == -1 && message.indexOf('<') == -1 && message.indexOf('§') == -1) {
+            return Component.text(message);
+        }
+
         if (message.indexOf('<') != -1 && message.indexOf('>') != -1) {
             try {
                 return MINI_MESSAGE.deserialize(message);
@@ -37,6 +41,14 @@ public static Component parse(String message) {
         }
 
         String processed = message.replace('&', '§');
+        if (processed.indexOf('#') == -1) {
+            try {
+                return LegacyComponentSerializer.legacySection().deserialize(processed);
+            } catch (Exception e) {
+                return Component.text(message).color(NamedTextColor.WHITE);
+            }
+        }
+
         Matcher matcher = HEX_COLOR_PATTERN.matcher(processed);
         if (!matcher.find()) {
             try {
@@ -45,8 +57,9 @@ public static Component parse(String message) {
                 return Component.text(message).color(NamedTextColor.WHITE);
             }
         }
+        
         matcher.reset();
-        StringBuilder sb = new StringBuilder(processed.length() + 32);
+        StringBuilder sb = new StringBuilder(processed.length() + (matcher.groupCount() * 14));
         int lastEnd = 0;
         while (matcher.find()) {
             sb.append(processed, lastEnd, matcher.start());

src/main/java/net/opmasterleo/combat/util/ChatUtil.java

@@ -1,5 +1,6 @@
 package net.opmasterleo.combat.util;
 
+import java.io.BufferedReader;
 import java.io.File;
 import java.io.FileInputStream;
 import java.io.FileOutputStream;
@@ -554,15 +555,15 @@ private static String extractHeader(File configFile) {
 
     private static String readSansHeader(File configFile) {
         if (configFile == null || !configFile.exists()) return null;
-        try (FileInputStream fis = new FileInputStream(configFile)) {
-            byte[] bytes = fis.readAllBytes();
-            String content = new String(bytes, StandardCharsets.UTF_8);
-            String[] lines = content.split("\r?\n", -1);
-            StringBuilder body = new StringBuilder();
+        try (BufferedReader reader = new BufferedReader(
+                new InputStreamReader(new FileInputStream(configFile), StandardCharsets.UTF_8))) {
+            StringBuilder body = new StringBuilder(1024);
+            String line;
             boolean started = false;
-            for (String line : lines) {
+            while ((line = reader.readLine()) != null) {
                 if (!started) {
-                    if (line.trim().startsWith("#") || line.trim().isEmpty()) {
+                    String trimmed = line.trim();
+                    if (trimmed.isEmpty() || trimmed.startsWith("#")) {
                         continue;
                     }
                     started = true;

src/main/java/net/opmasterleo/combat/util/ConfigUtil.java

@@ -265,32 +265,6 @@ private static String getRegionKey(Location location) {
         return location.getWorld().getName() + ":" + (location.getBlockX() >> 9) + ":" + (location.getBlockZ() >> 9);
     }
 
-    private static boolean shouldThrottleRegion(Location location, long minInterval) {
-        if (location == null || minInterval <= 0) {
-            return false;
-        }
-        return false;
-    }
-
-    private static boolean shouldThrottleEntity(Entity entity, long minInterval) {
-        if (entity == null || minInterval <= 0) {
-            return false;
-        }
-        return false;
-    }
-
-    private static void incrementRegionCounter(Location location) {
-        if (location != null) {
-            location.getWorld();
-        }
-    }
-
-    private static void incrementEntityCounter(Entity entity) {
-        if (entity != null) {
-            entity.getType();
-        }
-    }
-
     private static boolean canRunAsync() {
         return activeAsyncTasks.get() < MAX_CONCURRENT_ASYNC_TASKS;
     }
@@ -499,11 +473,6 @@ public static void runEntityTaskTimer(Plugin plugin, Entity entity, Runnable tas
     public static void runEntityTaskTimer(Plugin plugin, Entity entity, Runnable task, long delay, long period, long minInterval) {
         if (shouldSkip(plugin) || entity == null || !entity.isValid()) return;
 
-        if (minInterval > 0 && shouldThrottleEntity(entity, minInterval)) {
-            return;
-        }
-        
-        incrementEntityCounter(entity);
         Runnable wrapped = wrapTask(task, plugin, "entity");
 
         if (IS_FOLIA || IS_CANVAS) {
@@ -550,11 +519,6 @@ public static void runRegionTaskTimer(Plugin plugin, Location location, Runnable
     public static void runRegionTaskTimer(Plugin plugin, Location location, Runnable task, long delay, long period, long minInterval) {
         if (shouldSkip(plugin)) return;
 
-        if (minInterval > 0 && shouldThrottleRegion(location, minInterval)) {
-            return;
-        }
-        
-        incrementRegionCounter(location);
         Runnable wrapped = wrapTask(task, plugin, "region");
 
         if (IS_FOLIA || IS_CANVAS) {