Check that the available titles are not empty

Author: amontenegro

orcid-core/src/main/java/org/orcid/core/groupIds/issn/IssnClient.java

@@ -70,11 +70,12 @@ private IssnData extractIssnData(String issn, String json) throws JSONException
 
         // 1. Try to get mainTitle directly from the root
         if (rootObj.has("mainTitle")) {
-            String title = rootObj.getString("mainTitle");
-            String cleanTitle = cleanText(title);
-            issnData.setMainTitle(cleanTitle);
-            LOG.debug("Found mainTitle for '" + issn + "' " + cleanTitle);
-            return issnData;
+            String title = cleanText(rootObj.getString("mainTitle"));
+            if(StringUtils.isNotBlank(title)) {
+                issnData.setMainTitle(title);
+                LOG.debug("Found mainTitle for '" + issn + "' " + title);
+                return issnData;
+            }
         }
 
         // 2. Try to get the KeyTitle from the identifiedBy block
@@ -83,11 +84,12 @@ private IssnData extractIssnData(String issn, String json) throws JSONException
             if (identifiedBy.has("#KeyTitle")) {
                 JSONObject keyTitleObj = identifiedBy.getJSONObject("#KeyTitle");
                 if (keyTitleObj.has("value")) {
-                    String title = keyTitleObj.getString("value");
-                    String cleanTitle = cleanText(title);
-                    issnData.setMainTitle(cleanTitle);
-                    LOG.debug("Found KeyTitle for '" + issn + "' " + cleanTitle);
-                    return issnData;
+                    String title = cleanText(keyTitleObj.getString("value"));
+                    if(StringUtils.isNotBlank(title)) {
+                        issnData.setMainTitle(title);
+                        LOG.debug("Found KeyTitle for '" + issn + "' " + title);
+                        return issnData;
+                    }
                 }
             }
         }
@@ -109,9 +111,11 @@ private IssnData extractIssnData(String issn, String json) throws JSONException
 
             if (title != null && !title.isEmpty()) {
                 String cleanTitle = cleanText(title);
-                issnData.setMainTitle(cleanTitle);
-                LOG.debug("Found name for '" + issn + "' " + cleanTitle);
-                return issnData;
+                if(StringUtils.isNotBlank(cleanTitle)) {
+                    issnData.setMainTitle(cleanTitle);
+                    LOG.debug("Found name for '" + issn + "' " + cleanTitle);
+                    return issnData;
+                }
             }
         }
 

orcid-core/src/test/resources/issn-response-use-key-title.json

@@ -48,6 +48,7 @@
     "status": "recordStatus:Register",
     "type": "schema:CreativeWork"
   },
+  "mainTitle": "",
   "name": [
     "Nature chemistry.",
     "Nature chemistry"

orcid-core/src/test/resources/issn-response-use-name-array.json

@@ -32,6 +32,7 @@
     "status": "recordStatus:Register",
     "type": "schema:CreativeWork"
   },
+  "mainTitle": "",
   "name": [
     "Journal of food engineering - Array"
   ],

orcid-scheduler-web/src/main/java/org/orcid/scheduler/loader/source/issn/IssnLoadSource.java

@@ -140,6 +140,9 @@ private void updateIssnGroupIdRecords() {
                     } catch(JSONException e) {
                         LOG.warn("JSONException for issn {}", issn);
                         recordFailure(issnEntity, "JSONException");
+                    } catch (IllegalArgumentException e) {
+                        LOG.warn("IllegalArgumentException for issn {}", issn);
+                        recordFailure(issnEntity, "IllegalArgumentException");
                     }
                 } else {
                     LOG.info("Issn for group record {} not valid: {}", issnEntity.getId(), issnEntity.getGroupId());