rebased IEEEST

Author: lukelowry

GridKit/Model/PhasorDynamics/Stabilizer/IEEEST/Ieeest.hpp

@@ -137,9 +137,6 @@ namespace GridKit
         RealT T4_{1};
         RealT T5_{0};
         RealT T6_{1};
-        RealT T2_inv_{1};
-        RealT T4_inv_{1};
-        RealT T6_inv_{1};
         RealT Ks_{1};
         RealT Lsmin_{-0.1};
         RealT Lsmax_{0.1};

GridKit/Model/PhasorDynamics/Stabilizer/IEEEST/IeeestImpl.hpp

@@ -49,12 +49,9 @@ namespace GridKit
       template <typename scalar_type, typename index_type>
       void Ieeest<scalar_type, index_type>::setDerivedParameters()
       {
-        T2_     = std::max(T2_, TIME_CONSTANT_MINIMUM);
-        T4_     = std::max(T4_, TIME_CONSTANT_MINIMUM);
-        T6_     = std::max(T6_, TIME_CONSTANT_MINIMUM);
-        T2_inv_ = ONE<RealT> / T2_;
-        T4_inv_ = ONE<RealT> / T4_;
-        T6_inv_ = ONE<RealT> / T6_;
+        T2_ = std::max(T2_, TIME_CONSTANT_MINIMUM);
+        T4_ = std::max(T4_, TIME_CONSTANT_MINIMUM);
+        T6_ = std::max(T6_, TIME_CONSTANT_MINIMUM);
 
         a1_ = A1_ + A3_;
         a2_ = A2_ + A4_ + A1_ * A3_;
@@ -352,9 +349,9 @@ namespace GridKit
         const ScalarT x2_rhs = (-x1 - a1_ * x2 + u) * a2_inv_;
         const ScalarT x3_rhs = (-x1 - a1_ * x2 - a2_ * x3 + u) * a3_inv_;
         const ScalarT x4_rhs = (-x1 - a1_ * x2 - a2_ * x3 - a3_ * x4 + u) * a4_inv_;
-        const ScalarT x5_rhs = (v4 - x5) * T2_inv_;
-        const ScalarT x6_rhs = (v5 - x6) * T4_inv_;
-        const ScalarT x7_rhs = (v6 - x7) * T6_inv_;
+        const ScalarT x5_rhs = (v4 - x5) / T2_;
+        const ScalarT x6_rhs = (v5 - x6) / T4_;
+        const ScalarT x7_rhs = (v6 - x7) / T6_;
 
         f[X1] = -x1_dot + s1 * x1_rhs + (s2 + s3 + s4) * x2;
         f[X2] = -x2_dot + s2 * x2_rhs + (s3 + s4) * x3;

GridKit/Model/PhasorDynamics/Stabilizer/IEEEST/README.md

@@ -3,7 +3,8 @@
 Standard IEEE power system stabilizer: 4th-order notch filter, two lead–lag
 blocks, washout, and output limiter.
 
-Notes:
+## Notes
+
 - $V_{\mathrm{cl}}$, $V_{\mathrm{cu}}$, and $T_{\mathrm{delay}}$ are accepted for input-format
   compatibility but are not modeled.
 
@@ -69,6 +70,13 @@ IEEEST denominator time constants are conditioned and unsupported notch forms ar
 \end{aligned}
 ```
 
+## Model Ports
+
+Name     | Port   | Init  | Description
+---------|--------|-------|------
+`input`  | Input  | Known | Stabilizer input signal
+`output` | Output | Known | Stabilizer output signal
+
 ## Model Variables
 
 ### Internal Variables
@@ -188,11 +196,11 @@ The output limiter uses GridKit's smooth
 
 ## Initialization
 
-### External Priors
+### Input Initialization
 
 ```math
 \begin{aligned}
-  u_0 &\leftarrow \text{stabilizer input signal}
+  u &\leftarrow \text{stabilizer input signal}
 \end{aligned}
 ```
 
@@ -208,7 +216,7 @@ The output limiter uses GridKit's smooth
 \end{aligned}
 ```
 
-### External Solved
+### Output Initialization
 
 None.