Reorganization in preparation for Enzyme automatic differentiation PR#126
Merged
Conversation
pelesh
requested changes
Jun 4, 2025
pelesh
left a comment
pelesh
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! Just rebase and fix any compiler warnings. I also suggest to add a todo note in Model/Evaluator.hpp
nkoukpaizan
force-pushed
the
nicholson/autodiff-prep
branch
from
64e16d5 to
70e9d4f
Compare
pelesh
approved these changes
Jun 5, 2025
pelesh
left a comment
pelesh
left a comment
Collaborator
There was a problem hiding this comment.
Builds cleanly, tests pass, good to go.
6 tasks
WiktoriaZielinskaORNL
pushed a commit
that referenced
this pull request
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reorganization in preparation for Enzyme automatic differentiation PR.
Proposed changes
src/LinearAlgebra/SparsityPattern/tosrc/AutomaticDifferentiation/DependencyTracking/COO_Matrixinto theGridKit::LinearAlgebranamespace.~enzymespec to CI. Since Enzyme is an optional dependency for now, we need to ensure we can still build without it.Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
This PR should not be a heavy load to review.
This is an attempt to break up #124 into more manageable PRs. I am working on disabling Enzyme derivatives and related tests when
GRIDKIT_ENABLE_ENZYME=Off.