fix several memory leaks#134
Merged
Merged
Conversation
pelesh
requested changes
Jun 10, 2025
pelesh
left a comment
pelesh
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for catching this. A couple of minor changes requested.
pelesh
approved these changes
Jun 11, 2025
WiktoriaZielinskaORNL
pushed a commit
that referenced
this pull request
Jul 23, 2025
--------- Co-authored-by: superwhiskers <superwhiskers@users.noreply.github.com> Co-authored-by: pelesh <peless@ornl.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes several memory leaks i found in the progress of reviewing an unrelated pull request. my bandage solution to fixing the leaked memory caused by repeated calls to
initializeBackwardSimulationmay not be the best way of fixing that problem, so alternative solutions are welcome