Skip to content

Adding new version of example3 with GenClassical#148

Merged
pelesh merged 3 commits into
developfrom
create-example3classical
Jun 20, 2025
Merged

Adding new version of example3 with GenClassical#148
pelesh merged 3 commits into
developfrom
create-example3classical

Conversation

@abirchfield

@abirchfield abirchfield commented Jun 19, 2025

Copy link
Copy Markdown
Collaborator

Description

Adding new version of example3 with GenClassical, plus necessary bug fixes.

Proposed changes

  • New Example3_GenClassical example
  • Bug fixes on GenClassical model itself
  • Correction to GenClassical documentation
  • Correction to GenClassical tests

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.

@abirchfield abirchfield self-assigned this Jun 19, 2025
@abirchfield abirchfield added bug Something isn't working examples labels Jun 19, 2025
@abirchfield abirchfield marked this pull request as ready for review June 19, 2025 19:28
@abirchfield abirchfield requested a review from pelesh June 19, 2025 19:28

@pelesh pelesh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

@pelesh pelesh merged commit 721ed57 into develop Jun 20, 2025
@abirchfield abirchfield deleted the create-example3classical branch June 20, 2025 14:03
WiktoriaZielinskaORNL pushed a commit that referenced this pull request Jul 23, 2025
* adding new version of example3 with GenClassical, plus fixes to GenClassical itself and other bug fixes

* updated GenClassical unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working examples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants