Signal Bus Implementation#153
Closed
lukelowry wants to merge 27 commits into
Closed
Conversation
…GridKit into lukel/phasor_signalbus_dev
Collaborator
|
Planning to return to this after implementing example with governor (without signals, requiring direct Genrou-Tgov1 connections that will later be deleted). |
Collaborator
Author
|
Needs rework, deleting branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR proposes an initial implementation of BusSignal. This is used to read/write data between phasor dynamics models, which is a necessary feature to implement governor and exciter models.
Proposed changes
The following changes are proposed. Temporarily, the real value of the bus votlage$V_r$ is used for the input/output of $\omega$ and $P_m$ for Genrou and TGOV1.
Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
Unit tests are waiting until the general approach is approved by @pelesh and @abirchfield .
Unclear if specific read/write permissions need to be set for the signal. The BusSignal class has been implemented to treat signals similarly to network KCL, such that any model that has access to the signal can also read/write.
While this specific implementation is subject to revision, this will allow a governor example to be implemented.