Skip to content

Signal Bus Implementation#153

Closed
lukelowry wants to merge 27 commits into
developfrom
lukel/phasor_signalbus_dev
Closed

Signal Bus Implementation#153
lukelowry wants to merge 27 commits into
developfrom
lukel/phasor_signalbus_dev

Conversation

@lukelowry

@lukelowry lukelowry commented Jun 25, 2025

Copy link
Copy Markdown
Collaborator

Description

This PR proposes an initial implementation of BusSignal. This is used to read/write data between phasor dynamics models, which is a necessary feature to implement governor and exciter models.

Proposed changes

The following changes are proposed. Temporarily, the real value of the bus votlage $V_r$ is used for the input/output of $\omega$ and $P_m$ for Genrou and TGOV1.

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.

Further comments

Unit tests are waiting until the general approach is approved by @pelesh and @abirchfield .

Unclear if specific read/write permissions need to be set for the signal. The BusSignal class has been implemented to treat signals similarly to network KCL, such that any model that has access to the signal can also read/write.

While this specific implementation is subject to revision, this will allow a governor example to be implemented.

lukelowry added 24 commits June 25, 2025 10:51
@lukelowry lukelowry requested review from abirchfield and pelesh June 25, 2025 18:43
@lukelowry lukelowry self-assigned this Jun 25, 2025
@abirchfield abirchfield marked this pull request as draft June 25, 2025 20:38
@abirchfield

Copy link
Copy Markdown
Collaborator

Planning to return to this after implementing example with governor (without signals, requiring direct Genrou-Tgov1 connections that will later be deleted).

@lukelowry

Copy link
Copy Markdown
Collaborator Author

Needs rework, deleting branch.

@lukelowry lukelowry closed this Jun 26, 2025
@lukelowry lukelowry deleted the lukel/phasor_signalbus_dev branch June 26, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants