Add VectorHandler class to GridKit#480
Merged
Merged
Conversation
pelesh
requested review from
abdourahmanbarry,
alexander-novo,
lukelowry and
nkoukpaizan
and removed request for
abdourahmanbarry
shakedregev
reviewed
Jul 8, 2026
shakedregev
reviewed
Jul 8, 2026
Co-authored-by: Shaked Regev <35384901+shakedregev@users.noreply.github.com>
Co-authored-by: Shaked Regev <35384901+shakedregev@users.noreply.github.com>
shakedregev
reviewed
Jul 8, 2026
shakedregev
reviewed
Jul 8, 2026
shakedregev
reviewed
Jul 8, 2026
shakedregev
reviewed
Jul 8, 2026
shakedregev
reviewed
Jul 8, 2026
shakedregev
left a comment
shakedregev
left a comment
Collaborator
There was a problem hiding this comment.
I still need to test this, but overall looks good. Very minor comment changes.
…sts.hpp Co-authored-by: Shaked Regev <35384901+shakedregev@users.noreply.github.com>
…sts.hpp Co-authored-by: Shaked Regev <35384901+shakedregev@users.noreply.github.com>
shakedregev
approved these changes
Jul 8, 2026
shakedregev
left a comment
shakedregev
left a comment
Collaborator
There was a problem hiding this comment.
Tested and looks good. Add a changelog update and make sure to run CI.
alexander-novo
approved these changes
Jul 9, 2026
alexander-novo
left a comment
alexander-novo
left a comment
Collaborator
There was a problem hiding this comment.
Once int template instantiations are added for all of the new Vector types, everything works properly with the new Rosenbrock integrator.
lukelowry
approved these changes
Jul 9, 2026
lukelowry
left a comment
lukelowry
left a comment
Collaborator
There was a problem hiding this comment.
One issue I think I spotted. It is good to see our local library chugging along! Thank you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
VectorHandlerclass adds portable BLAS operations for `GridKit::LinearAlgebra::Vector.CC @shakedregev @abdourahmanbarry
Proposed changes
Port BLAS operations implemented in Re::Solve library to GridKit and re-use portability features from there.
BLAS operations are needed to support GridKit's native numerical integrator based on Rosenbrock method (see #479).
Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
We should consider whether to separate sparse BLAS operations from Re::Solve into a separate library that could be reused between multiple applications.