OS-110 phpcs formatting

Author: stankut

modules/os2forms_attachment/src/Element/AttachmentElement.php

@@ -2,7 +2,6 @@
 
 namespace Drupal\os2forms_attachment\Element;
 
-use Drupal\Core\File\FileSystemInterface;
 use Drupal\webform\Entity\WebformSubmission;
 use Drupal\webform\WebformSubmissionInterface;
 use Drupal\webform_attachment\Element\WebformAttachmentBase;
@@ -76,7 +75,7 @@ public static function getFileContent(array $element, WebformSubmissionInterface
         // Save printable document.
         $print_engine = $print_engine_manager->createSelectedInstance($element['#export_type']);
 
-        // Adding digital signature
+        // Adding digital signature.
         if (isset($element['#digital_signature']) && $element['#digital_signature']) {
           $file_path = $print_builder->savePrintableDigitalSignature([$webform_submission], $print_engine, $scheme, $file_name);
         }

modules/os2forms_attachment/src/Os2formsAttachmentPrintBuilder.php

@@ -33,8 +33,8 @@ public function printHtml(EntityInterface $entity, $use_default_css = TRUE, $opt
   /**
    * Modified version of the original savePrintable() function.
    *
-   * The only difference is modified call to prepareRenderer with digitalPost flag
-   * TRUE.
+   * The only difference is modified call to prepareRenderer with digitalPost
+   * flag TRUE.
    *
    * @see PrintBuilder::savePrintable()
    *
@@ -65,8 +65,6 @@ public function savePrintableDigitalSignature(array $entities, PrintEngineInterf
   /**
    * Override prepareRenderer() the print engine with the passed entities.
    *
-   * @see PrintBuilder::prepareRenderer
-   *
    * @param array $entities
    *   An array of entities.
    * @param \Drupal\entity_print\Plugin\PrintEngineInterface $print_engine
@@ -78,8 +76,10 @@ public function savePrintableDigitalSignature(array $entities, PrintEngineInterf
    *
    * @return \Drupal\entity_print\Renderer\RendererInterface
    *   A print renderer.
+   *
+   * @see PrintBuilder::prepareRenderer
    */
-  protected function prepareRenderer(array $entities, PrintEngineInterface $print_engine, $use_default_css, $digitalSignature = false) {
+  protected function prepareRenderer(array $entities, PrintEngineInterface $print_engine, $use_default_css, $digitalSignature = FALSE) {
     if (empty($entities)) {
       throw new \InvalidArgumentException('You must pass at least 1 entity');
     }

modules/os2forms_digital_signature/README.md

@@ -29,7 +29,7 @@ URL: `admin/os2forms_digital_signature/settings`
 
 - **Signature server URL**
 
-  The URL of the service providing digital signature. This is the example of a known service https://signering.bellcom.dk/sign.php?
+  The URL of the service providing digital signature. This is the example of a known service [https://signering.bellcom.dk/sign.php?](https://signering.bellcom.dk/sign.php?)
 
 - **Hash Salt used for signature**
 

modules/os2forms_digital_signature/os2forms_digital_signature.services.yml

@@ -7,6 +7,7 @@ services:
     class: Drupal\os2forms_digital_signature\Service\SigningService
     arguments:
       - '@http_client'
+      - '@datetime.time'
       - '@config.factory'
       - '@entity_type.manager'
       - '@logger.channel.os2forms_digital_signature'

modules/os2forms_digital_signature/src/Service/SigningService.php

@@ -2,6 +2,7 @@
 
 namespace Drupal\os2forms_digital_signature\Service;
 
+use Drupal\Component\Datetime\TimeInterface;
 use Drupal\Core\Config\ConfigFactoryInterface;
 use Drupal\Core\Config\ImmutableConfig;
 use Drupal\Core\Entity\EntityStorageInterface;
@@ -39,6 +40,7 @@ class SigningService {
 
   public function __construct(
     private readonly ClientInterface $httpClient,
+    private readonly TimeInterface $time,
     ConfigFactoryInterface $configFactory,
     EntityTypeManager $entityTypeManager,
     private readonly LoggerChannelInterface $logger,
@@ -184,7 +186,7 @@ public function deleteStalledSubmissions() : void {
     $digitalSignatureWebforms = [];
 
     // Finding webforms that have any handler.
-    $query = \Drupal::entityQuery('webform')
+    $query = $this->webformStorage->getQuery()
       ->exists('handlers');
     $handler_webform_ids = $query->execute();
 
@@ -217,7 +219,7 @@ public function deleteStalledSubmissions() : void {
 
     // Find all stalled webform submissions of digital signature forms.
     $retention_period = ($this->config->get('os2forms_digital_signature_submission_retention_period')) ?? 300;
-    $timestamp_threshold = \Drupal::time()->getRequestTime() - $retention_period;
+    $timestamp_threshold = $this->time->getRequestTime() - $retention_period;
     $query = $this->webformSubmissionStorage->getQuery()
       ->accessCheck(FALSE)
       ->condition('webform_id', $digitalSignatureWebforms, 'IN')