Codereview digital signature

[lilosti]

We have been asked to do at codereview of the digital signature PR. Any discussions about the codereview should be added as comments to this - or on the PR (depending on the nature of the discussion).

[ChatBotBerg]

@lilosti:

please provide an update / status on this issue ( in a comment) and tag @ds-bellcom in this status

please also provide

• details regarding the review in this issue - including what's review, milestones and result
• preference to issues identify and raised as a result of this review

I expect discussions regarding the review to be documentet in this issus and issues identifyed during the review to be raised at child issues

[lilosti]

Hi @ChatBotBerg and @ds-bellcom,

We have started doing codereview. We have requested changes and are now awaiting Bellcom.

/Line

[ChatBotBerg]

@ds-bellcom: Please provide details regarding progress in implementing the required changes, providing me with a delivery date for digital signatur.

Best/Anna-Lis

[ds-bellcom]

Hi @lilosti and @ChatBotBerg.

I have now answered @rimi-itk question regarding #167 and are now awaiting review from ITK.

Depending on what ITK returns with after review, we expect to be able to deliver the solution approx 1-2 weeks after review.

@lilosti, will you let me know when ITK are done with the review?

[rimi-itk]

@ds-bellcom, a pull request with 4 failing code checks is not ready for review: https://github.com/OS2Forms/os2forms/actions/runs/14616182422

[ds-bellcom]

You may be right about that @rimi-itk. But as you write yourself, most of them should be resolved after merging #168.

We will review #168 on Wednesday, May 28th (as I have written here: #171).

[rimi-itk]

I'm not sure in which order you expect thing to happen, but I've added some comments on #167. Most are about inconsistencies within the new code and with the rest of the https://github.com/OS2Forms/os2forms project, and many of them could (probably) have been detected by proper code checks.

[ds-bellcom]

Hi @lilosti and @ChatBotBerg.

Stan has changed what @rimi-itk found in his review. Stan has asked @rimi-itk to make a new review. Would you please let me know when @rimi-itk has made a new review?

[ds-bellcom]

Hi @lilosti and @ChatBotBerg.

Stan have merged the PR from #167 to develop.