Fix hardcoded string composition with internationalizations (#5293)#5312
Conversation
| before(:all) do | ||
| upload_portal_config('portal.yml') | ||
| update_ood_portal | ||
| restart_apache | ||
| restart_dex | ||
| end |
There was a problem hiding this comment.
I'm hesitant to add this. Seems like it could cause more flakiness to be bouncing things all the time.
Bubballoo3
left a comment
Bubballoo3
left a comment
There was a problem hiding this comment.
It seems like the only open question is the modifications to the E2E tests, so you should just split that out into a separate change so we can properly discuss them
github-project-automation
Bot
moved this from Awaiting Review
to Changes Requested
in PR Review Pipeline
|
I removed the E2E changes, and it passed the failing test on the rerun attempt. I'm thinking it might have just been a flaky run all along. I removed the E2E changes so this PR is just the i18n stuff now. |
Bubballoo3
left a comment
Bubballoo3
left a comment
There was a problem hiding this comment.
The content here looks good and works well. I added a few notes on the locale file, such as making sure that keys are sorted and only en.yml is changed. I also wonder if we want to remove the unused keys that this creates (batch_connect_sessions_relaunch_title for example is not used elsewhere and would probably be duplicated as dashboard.relaunch if it is ever needed in the future), but leaving them is probably the safest option for the moment.
There was a problem hiding this comment.
We should only update this file. Weekly automation will bring the other locale files up to date
| files_title: File browsing | ||
| page_title: "%{page} - %{site}" | ||
| page_title_with_dir: "%{page} - %{site} - %{dir}" | ||
| root: Root |
There was a problem hiding this comment.
These new keys should be placed in alphabetical order
bstepanovski
force-pushed
the
bug-fix/hardcoded-translation-strings-5293
branch
from
38b6ddd to
92f1d37
Compare
bstepanovski
force-pushed
the
bug-fix/hardcoded-translation-strings-5293
branch
from
84dd3a7 to
f1eaf8b
Compare
github-project-automation
Bot
moved this from Changes Requested
to Merged/Closed
in PR Review Pipeline
4 participants
Fixes #5293