used regex to ensure env is filled out#5356
Merged
Merged
Conversation
Contributor
|
This looks good, but since the change itself isn't very self explanatory it might be good to add a test that demonstrates the original bug to ensure this stays fixed |
clooty217
force-pushed
the
bug-fix/empty-env-var-error-5335
branch
from
71c3e0a to
27adee2
Compare
Contributor
|
Thanks so much for the tests Trevor! |
Contributor
|
I am going to explore if we can add validation in the javascript to provide some warning instead of just saving the form without the malformed variable. But I am happy to take this over since today is Trevor's last day. |
github-project-automation
Bot
moved this from Awaiting Review
to Merged/Closed
in PR Review Pipeline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #5335
changed a string lookup to only select if the param key has data after auto_environment_variable
tested by creating a new launcher and trying to reproduce the bug in the original issue.
ran project manager tests