Normalize dynamic batch connect tokens with underscores (#4251)#5462
Open
bstepanovski wants to merge 3 commits into
Open
Normalize dynamic batch connect tokens with underscores (#4251)#5462bstepanovski wants to merge 3 commits into
bstepanovski wants to merge 3 commits into
Conversation
Contributor
|
This looks good, but I think I am a little nervous to be relying on the
Let's add a system test case just to make sure that other pieces allowing this approach to work with dynamic forms don't break. |
Contributor
Author
|
I've added a system test for this. Let me know if you think it should be covered differently or if there’s a better place for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4251
_with-when buildingdata-option-for-cluster-*values in accounts, queues, and auto modules