Skip to content

Normalize dynamic batch connect tokens with underscores (#4251)#5462

Open
bstepanovski wants to merge 3 commits into
masterfrom
bug-fix/dynamic-bc-underscore-tokenization-4251
Open

Normalize dynamic batch connect tokens with underscores (#4251)#5462
bstepanovski wants to merge 3 commits into
masterfrom
bug-fix/dynamic-bc-underscore-tokenization-4251

Conversation

@bstepanovski
Copy link
Copy Markdown
Contributor

Fixes #4251

  • Updated cluster key generation to replace _ with - when building data-option-for-cluster-* values in accounts, queues, and auto modules
  • Added tests to cover cluster IDs with underscores and confirm the generated keys use hyphens instead

@Bubballoo3
Copy link
Copy Markdown
Contributor

This looks good, but I think I am a little nervous to be relying on the

Interestingly enough - if you have a cluster, say ascend_nextgen you can use data-option-for-cluster-ascend-nextgen and it continues to work. (From #4251 (comment))

Let's add a system test case just to make sure that other pieces allowing this approach to work with dynamic forms don't break.

@bstepanovski
Copy link
Copy Markdown
Contributor Author

I've added a system test for this. Let me know if you think it should be covered differently or if there’s a better place for it.

@bstepanovski bstepanovski requested a review from Bubballoo3 May 19, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Awaiting Review

Development

Successfully merging this pull request may close these issues.

dynamic batch connect values with _ don't work properly

3 participants