fixed warnings

Author: At11011

oscps-lib/src/blocks.rs

@@ -7,26 +7,27 @@
 //! MassBalance trait but not the EnergyBalance.
 //!
 
-
-use uom::si::f64::{Energy};
-use uom::si::f64::{Mass};
+use uom::si::f64::Energy;
+use uom::si::f64::Mass;
 use uom::si::mass::kilogram;
 use uom::si::energy::joule;
-use crate::component::ChemicalIdentifier;
-use crate::{component, connector};
+use crate::connector;
 use once_cell::sync::Lazy;
 
 //Initiallizing a global variable for the tolerance for the energy balance
+#[allow(dead_code)]
 static TOLERENCE_ENERGY: Lazy<Energy> = Lazy::new(|| Energy::new::<joule>(5.0));
 
 //Initiallizing a global variable for the tolerance for the mass balance
+#[allow(dead_code)]
 static TOLERENCE_MASS: Lazy<Mass> = Lazy::new(|| Mass::new::<kilogram>(5.0));
 
 //Initiallizing a global variable for the tolerance for the element balance
 
 /// Trait for ensuring the overall mass balance is maintained in a flowsheet.
 ///
 /// This trait can be implemented by any block that needs to ensure mass conservation.
+#[allow(dead_code)]
 pub trait MassBalance {
     // total mass in - total mass out < tolerance
     fn mass_balance_check(&self, mass_in : Mass, mass_out : Mass) -> bool {
@@ -44,6 +45,7 @@ pub trait MassBalance {
 /// This trait ensures that blocks in the flowsheet adhere to energy conservation principles.
 ///
 /// This is useful for distinguishing between "dynamic" and "steady state" simulations.
+#[allow(dead_code)]
 pub trait EnergyBalance {
 
     // total energy in - total energy out < tolerance
@@ -63,12 +65,12 @@ pub trait EnergyBalance {
     }
 }
 
-
 /// # Mixer Block
 /// 
 /// A block used for simple stream mixing operations.
 /// 
 /// This struct requires the implementation of both EnergyBalance and MassBalance traits to ensure proper conservation principles are followed.
+#[allow(dead_code)]
 pub struct Mixer {
     pub block_id : String,
     pub x_cord : i32,
@@ -86,12 +88,13 @@ impl MassBalance for Mixer {}
 // Applying the energy balance trait to the Mixer Block
 impl EnergyBalance for Mixer {}
 
+#[allow(dead_code)]
 impl Mixer {
     pub fn new(id : String, x_cord : i32, y_cord : i32, in_streams_mass : Vec<connector::Mconnector>, in_streams_energy : Vec<connector::Econnector>) -> Mixer {
         return Mixer {
             block_id : id,
-            x_cord : x_cord,
-            y_cord : y_cord,
+            x_cord,
+            y_cord,
             input_streams_mass : in_streams_mass,
             input_streams_energy : in_streams_energy,
             outlet_stream_mass : None,
@@ -115,7 +118,7 @@ impl Mixer {
     /// 
     /// A Mass quantity (uom object) that holds the outlet mass flow
     fn compute_total_outlet_mass_flow(&self) -> Option<f64> {
-       // steps to implement function:
+       // TODO: steps to implement function:
         // Need to loop through each of the connector structures and add up the mass flows
             // During this process, need to make sure that all the mass flows are in the same units
             // Use the UOM package to help with this part...
@@ -138,7 +141,6 @@ impl Mixer {
         return Some(energy_flow_sum);
     }
 
-
     fn compute_outlet_phase_fractions(&self) {
 
     }
@@ -158,7 +160,7 @@ mod block_tests {
     use crate::connector::{Mconnector, Econnector};
 
     use super::*;
-    use std::io;
+    // use std::io;
     use uom::si::f64::Energy;
     use uom::si::energy::kilojoule;
     use uom::si::mass::pound;

oscps-lib/src/component.rs

@@ -1,19 +1,18 @@
 //! # Component
-
 extern crate uom;
 
 extern crate pubchem;
 use anyhow::Result;
 
 /// This will hold the list of chemicals used within the simulation
+#[allow(dead_code)]
 pub struct ChemicalList {
     chemical_list : Vec<pubchem::Compound>
 }
 
-
-
 /// A struct to store information regarding the chemical properties of a particular substance.
 /// The "Chemical" struct is a wrapper for the pubchem::Compound object
+#[allow(dead_code)]
 pub struct Chemical {
     /// The (PubChem)[https://pubchem.ncbi.nlm.nih.gov/] CID of a compound.
     pub pubchem_obj : pubchem::Compound,
@@ -22,11 +21,13 @@ pub struct Chemical {
 
 /// This enum will be used by the "Chemical" struct to create the pubchem::Compound obj based on
 /// either the chemical name or the pubchem id of the chemical
+#[allow(dead_code)]
 pub enum ChemicalIdentifier {
     PubchemID(u32),
     CompoundName(String),
 }
 
+#[allow(dead_code)]
 impl Chemical {
 
     /// constructor
@@ -60,6 +61,7 @@ impl Chemical {
     }
 }
 
+#[allow(dead_code)]
 pub struct ChemicalProperties {
     pub molar_mass: f64,    // kg/mol
     pub critical_temp: f64, // K
@@ -80,11 +82,9 @@ impl ChemicalProperties {
 
 }
 
-
 #[cfg(test)]
 mod chemical_species_tests {
     use crate::component::{Chemical,ChemicalIdentifier};
-    use std::io;
 
     #[test]
     fn test_create_chemical_from_pubchem_id() {

oscps-lib/src/connector.rs

@@ -1,11 +1,13 @@
 //!here we will have 2 connector structs
     //!- Mass Streams
     //!- Energy Streams
+#[allow(dead_code)]
 pub struct Mconnector{
     pub m_conn_id: String,
     pub m_flow_total: f64
 }
 
+#[allow(dead_code)]
 impl Mconnector {
 
     pub fn new(id : String) -> Mconnector {
@@ -16,15 +18,13 @@ impl Mconnector {
     }
 }
 
-
-
+#[allow(dead_code)]
 pub struct Econnector{
     pub e_conn_id: String,
     pub energy_flow_total: f64
 }
 
-
-
+#[allow(dead_code)]
 impl Econnector {
 
     pub fn new(id : String) -> Econnector {

oscps-lib/src/lib.rs

@@ -4,6 +4,6 @@ mod component;
 mod simulation;
 mod thermodynamics;
 
-pub fn hello() ->  String {
+pub fn hello() -> String {
     "Hello, world!".to_string()
 }

oscps-lib/src/simulation.rs

@@ -1,6 +1,17 @@
 // use std::collections::HashMap;
 
-// #[derive(Debug, Clone)]
+    // fn compute_outlet_phase_fractions(&self) {
+
+    // }
+
+    // fn compute_outlet_temperature(&self) {
+
+    // }
+
+    // fn compute_outlet_pressure(&self) {
+
+    // }
+ // #[derive(Debug, Clone)]
 // struct Settings {
 //     // Add fields as needed
 // }

oscps-lib/src/thermodynamics.rs

@@ -10,20 +10,23 @@ use uom::si::thermodynamic_temperature::kelvin;
 use uom::si::pressure::pascal;
 use crate::component::Chemical;
 
+#[allow(dead_code)]
 pub enum ThermodynamicConstants {
     UniversalGasConstant, // R
     StandardTemperature,  // T_0
     StandardPressure,     // P_0
     AvogadroNumber,       // N_A
 }
 
+#[allow(dead_code)]
 /// Enum for representing different types of thermodynamic constant values
 pub enum ConstantValue {
     Pressure(Pressure),
     Temperature(ThermodynamicTemperature),
     Dimensionless(f64),
 }
 
+#[allow(dead_code)]
 impl ThermodynamicConstants {
     /// Returns the value of the thermodynamic constant with its appropriate type.
     pub fn value(&self) -> ConstantValue {
@@ -44,17 +47,20 @@ impl ThermodynamicConstants {
     }
 }
 
+#[allow(dead_code)]
 pub struct ThermoState {
     pub pressure: Pressure,                // Pressure in Pascals
     pub temperature: ThermodynamicTemperature, // Temperature in Kelvin
     pub mass_list: Vec<SpeciesListPair>, // Mole fractions, typically unitless
 }
 
+#[allow(dead_code)]
 pub struct SpeciesListPair {
     pub chemical_species : Chemical,
     pub mass_quantity : Mass  
 }
 
+#[allow(dead_code)]
 impl ThermoState {
     // Constructor for creating a ThermoState
     pub fn new(
@@ -150,7 +156,7 @@ mod thermo_tests {
             },
         };
 
-        let Anisdine = Chemical {
+        let anisdine = Chemical {
             pubchem_obj : pubchem::Compound::new(7732),
             properties : ChemicalProperties {
                 molar_mass: 123.155, // g/mol, converting to kg/mol = 123.155 / 1000
@@ -168,7 +174,7 @@ mod thermo_tests {
 
         let anisidine_mass = Mass::new::<kilogram>(8.0);
         let anisidine_species_pair = SpeciesListPair {
-            chemical_species : Anisdine,
+            chemical_species : anisdine,
             mass_quantity : anisidine_mass
         };