fix conftest boolean option#154
Merged
Merged
Conversation
Collaborator
|
Hey Daan, this seems to be failing some tests... |
Contributor
I believe the macOS failures are not from the change, they are pre-existing CI issues:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made in this PR
Fixes the boolean option in the conftest. The old implementation was set to True if anything was supplied to the --ricianNoise or --usePrior (also if you supply the False argument). To fix this, the new implementation is set to False as default but when --ricianNoise or --usePrior flags are supplied is set to True.
Checklist