Skip to content

Commit 284a16d

Browse files
fix: Resolve CS9113 unused parameter warnings (#671)
* fix: Resolve CS9113 warning for unused logger parameters in examples Co-authored-by: berezovskyi <64734+berezovskyi@users.noreply.github.com> * fix: Use source-generated logging to resolve CS9113 unused parameter warnings Co-authored-by: berezovskyi <64734+berezovskyi@users.noreply.github.com> * fix: Use static source-generated logging for unused ILogger variables in examples Co-authored-by: berezovskyi <64734+berezovskyi@users.noreply.github.com> --------- Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: berezovskyi <64734+berezovskyi@users.noreply.github.com>
1 parent ef2eb27 commit 284a16d

4 files changed

Lines changed: 21 additions & 4 deletions

File tree

OSLC4Net_SDK/Examples/OSLC4NetExamples.Server.NetCoreApi/Controllers/CatalogController.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ public class CatalogController(ILogger<CatalogController> logger) : ControllerBa
1818
[HttpGet]
1919
public ServiceProviderCatalog Get()
2020
{
21+
logger.LogGetCatalog();
2122
var catalog = new ServiceProviderCatalog();
2223
catalog.SetAbout(new Uri(Request.GetEncodedUrl()));
2324
var sp = new ServiceProvider();
@@ -29,6 +30,7 @@ public ServiceProviderCatalog Get()
2930
[HttpPut]
3031
public ServiceProviderCatalog Put(ServiceProvider sp)
3132
{
33+
logger.LogPutCatalog();
3234
var catalog = new ServiceProviderCatalog();
3335
catalog.AddServiceProvider(sp);
3436
return catalog;
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
namespace OSLC4NetExamples.Server.NetCoreApi.Controllers;
2+
3+
internal static partial class ControllerLogExtensions
4+
{
5+
[LoggerMessage(EventId = 1, Level = LogLevel.Debug, Message = "Getting service provider catalog.")]
6+
public static partial void LogGetCatalog(this ILogger logger);
7+
8+
[LoggerMessage(EventId = 2, Level = LogLevel.Debug, Message = "Putting service provider catalog.")]
9+
public static partial void LogPutCatalog(this ILogger logger);
10+
11+
[LoggerMessage(EventId = 3, Level = LogLevel.Debug, Message = "Getting service provider with id: {Id}")]
12+
public static partial void LogGetProvider(this ILogger logger, string id);
13+
14+
[LoggerMessage(EventId = 4, Level = LogLevel.Debug, Message = "Getting resource with id: {Id}")]
15+
public static partial void LogGetResource(this ILogger logger, string id);
16+
}

OSLC4Net_SDK/Examples/OSLC4NetExamples.Server.NetCoreApi/Controllers/Resources/ResourceController.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,8 @@ namespace OSLC4NetExamples.Server.NetCoreApi.Controllers;
55
[ApiController]
66
public abstract class ResourceController<T>(ILogger<ResourceController<T>> logger) : ControllerBase
77
{
8+
protected ILogger<ResourceController<T>> Logger { get; } = logger;
9+
810
[HttpGet]
911
public abstract T GetResource(string id);
10-
// {
11-
// var tInstance = ActivatorUtilities.CreateInstance<T>(HttpContext.RequestServices, id);
12-
// return tInstance;
13-
// }
1412
}

OSLC4Net_SDK/Examples/OSLC4NetExamples.Server.NetCoreApi/Controllers/ServiceProviderController.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ public class ServiceProviderController(ILogger<ServiceProviderController> logger
1414
[Route("{id}")]
1515
public ServiceProvider GetProvider(string id)
1616
{
17+
logger.LogGetProvider(id);
1718
var sp = new ServiceProvider();
1819
sp.SetAbout(new Uri(Request.GetEncodedUrl()));
1920
sp.SetDescription($"Service Provider for {id}");

0 commit comments

Comments
 (0)