From dedc39dce565f2f14edd5324656695b20cdc277c Mon Sep 17 00:00:00 2001
From: Gerni <47844854+mgerni@users.noreply.github.com>
Date: Thu, 15 May 2025 13:48:34 -0400
Subject: [PATCH] fix temple sync again

---
 templates/collection_log_import.html |  1 +
 templesync.py                        | 27 ++++++++++++++++++---------
 2 files changed, 19 insertions(+), 9 deletions(-)

diff --git a/templates/collection_log_import.html b/templates/collection_log_import.html
index 341fc9f..a8fe766 100644
--- a/templates/collection_log_import.html
+++ b/templates/collection_log_import.html
@@ -18,6 +18,7 @@ <h3 class="center">Import Results For: <p class="incomplete">{{rs_username}}</p>
     <div class="rank-results-row center">
         <p class="complete">Elite Tasks: <p class="incomplete">{{elite}}</p></p>
     </div>
+    <p>Reminder: Dairy Tasks are not tracked via TempleOSRS you will need to manually complete.</p>
     <h5 class="center">Browse a task list to see what tasks you've completed already!</h3>
 </div>
 
diff --git a/templesync.py b/templesync.py
index e2ce86c..87a82f6 100644
--- a/templesync.py
+++ b/templesync.py
@@ -40,6 +40,8 @@ def import_logs(player_name: str, site_tasks: list):
 
 
 def check_logs(username: str, site_tasks: list, action: str):
+    def find_by_id(items, target_id):
+        return [item for item in items if item['id'] == target_id]
     def format_completed_tasks(completed_tasks: set):
         # iterate over the completed tasks and create a list of dictionaries
         formatted_tasks = []
@@ -49,7 +51,7 @@ def format_completed_tasks(completed_tasks: set):
             })
         return formatted_tasks
 
-    player_data = temple_player_data(username)
+    cleaned_player_data = temple_player_data(username)
     missing_tasks = list()
     completed_tasks = set()
     for task in site_tasks:
@@ -57,18 +59,25 @@ def format_completed_tasks(completed_tasks: set):
         if task_data:
             log_count = 0
             for item in task_data['include']:
-                for log_slot in player_data['data']['items']:
-                    if item['id'] == log_slot['id']:
-                        log_count += 1
+                print(f"Checking item: {item['name']} with ID: {item['id']}")
+                find_item = find_by_id(cleaned_player_data, item['id'])
+                if find_item:
+                    log_count += 1
+                    print(f"Found item: {find_item[0]['name']} with ID: {find_item[0]['id']}")
+                    print(f"Log count: {log_count}, Required: {task_data['logCount']}")
                     if log_count == task_data['logCount']:
                         completed_tasks.add(int(task['_id']))
+                        print(f"Completed task: {task['name']} with ID: {task['_id']}")
                         break
-                if log_count != task_data['logCount']:
-                    missing_tasks.append(task['name'])
-
-
+            if log_count != task_data['logCount']:
+                missing_tasks.append(task['name'])
+                print(f"Missing task: {task['name']} with ID: {task['_id']}")
+                    
     if action == 'check':
+        print("Missing tasks:")
+        for task in missing_tasks:
+            print(task)
         return missing_tasks
     else:
-        
+        print(completed_tasks)
         return format_completed_tasks(completed_tasks)
\ No newline at end of file