Fix logic issue in Junit file generator

JimLewis · JimLewis · commit a1aa566fc0e3 · 2026-02-27T10:26:31.000-08:00
diff --git a/ReportBuildDict2Junit.tcl b/ReportBuildDict2Junit.tcl
@@ -155,13 +155,15 @@ proc CreateJunitTestSuiteSummaries {TestDict TestSuiteSummary } {
         } else {
           set ElapsedTime missing
         }
-        if { $TestStatus ne "ANALYZE_FAILED" } {
+        if { $TestStatus eq "ANALYZE_FAILED" } {
           set TestStatus FAILED
         }
         if {[dict exists $TestCase Reason]} {
           set Reason [dict exists $TestCase Reason] 
+        } elseif {$TestStatus ne "PASSED"} {  ; # SKIPPED has a reason
+          set Reason "Test Case Error"
         } else {
-        set Reason "Test Case Error"
+          set Reason "Test Case Passed"   ; # does not print
         }
       } else {
         set TestStatus  "FAILED"

Original file line number	Diff line number	Diff line change
`@@ -155,13 +155,15 @@ proc CreateJunitTestSuiteSummaries {TestDict TestSuiteSummary } {`
`155`	`155`	`} else {`
`156`	`156`	`set ElapsedTime missing`
`157`	`157`	`}`
`158`		`- if { $TestStatus ne "ANALYZE_FAILED" } {`
	`158`	`+ if { $TestStatus eq "ANALYZE_FAILED" } {`
`159`	`159`	`set TestStatus FAILED`
`160`	`160`	`}`
`161`	`161`	`if {[dict exists $TestCase Reason]} {`
`162`	`162`	`set Reason [dict exists $TestCase Reason]`
	`163`	`+ } elseif {$TestStatus ne "PASSED"} { ; # SKIPPED has a reason`
	`164`	`+ set Reason "Test Case Error"`
`163`	`165`	`} else {`
`164`		`- set Reason "Test Case Error"`
	`166`	`+ set Reason "Test Case Passed" ; # does not print`
`165`	`167`	`}`
`166`	`168`	`} else {`
`167`	`169`	`set TestStatus "FAILED"`