feat: 将敏感 AI 功能路由分组并添加数据源管理权限控制，同时为 SQL 查询增加结果集限制，并增强了命令执行的安全性。

Author: OSpoon

backend/app/services/query_execution_service.ts

@@ -65,15 +65,24 @@ export default class QueryExecutionService {
     }
 
     try {
+      // Safety check: Enforce a firm limit on results to prevent OOM
+      let finalSql = sql.trim()
+      if (ds.type === 'mysql' || ds.type === 'postgresql') {
+        finalSql = finalSql.replace(/;$/, '')
+        if (!/\bLIMIT\b/i.test(finalSql)) {
+          finalSql += ' LIMIT 1000'
+        }
+      }
+
       if (ds.type === 'mysql') {
-        const { result, values } = replaceVars(sql, inputParams, 'sql')
+        const { result, values } = replaceVars(finalSql, inputParams, 'sql')
         executedSql = result
         const { client } = await DbHelper.getRawConnection(ds.id, timeout)
         const [rows] = await (client as any).execute({ sql: executedSql, values, timeout })
         await client.end()
         queryResults = rows
       } else if (ds.type === 'postgresql') {
-        const { result, values } = replaceVars(sql, inputParams, 'pg')
+        const { result, values } = replaceVars(finalSql, inputParams, 'pg')
         executedSql = result
         const { client } = await DbHelper.getRawConnection(ds.id, timeout)
         try {
@@ -97,6 +106,14 @@ export default class QueryExecutionService {
           )
         }
 
+        // --- Phase 3: Critical Security Guard against Command Injection (RCE) ---
+        // Block all bash control operators, pipeline characters, command substitutions,
+        // environment variable access, and dangerous redirections to ensure `curl` cannot be escaped.
+        const forbiddenBashShellChars = /[;&|$`\n<>]/
+        if (forbiddenBashShellChars.test(commandToExecute)) {
+          throw new Error(`Command validation failed: Command contains forbidden shell meta-characters. Potential Command Injection isolated.`)
+        }
+
         const { stdout } = await execAsync(executedSql, {
           timeout,
           maxBuffer: 10 * 1024 * 1024,

backend/start/routes.ts

@@ -139,12 +139,18 @@ router
         // Execution
         router.post('query-tasks/:id/execute', [ExecutionController, 'execute'])
 
-        // AI Features
-        router.post('ai/test-connection', [AiController, 'testConnection'])
-        router.post('ai/optimize-sql', [AiController, 'optimizeSql'])
+        // Sensitive AI Features (Requires Data Source Management Permission)
+        router
+          .group(() => {
+            router.post('ai/test-connection', [AiController, 'testConnection'])
+            router.post('ai/optimize-sql', [AiController, 'optimizeSql'])
+            router.post('ai/preview', [AiController, 'preview'])
+          })
+          .use(middleware.rbac({ permission: PERMISSIONS.MANAGE_DATA_SOURCES }))
+
+        // General AI Features (Dialogue & Learning)
         router.post('ai/chat', [AiController, 'chat'])
         router.post('ai/chat/stream', [AiController, 'chatStream'])
-        router.post('ai/preview', [AiController, 'preview'])
         router.post('ai/learn', [AiController, 'learn'])
         router.post('ai/transcribe', [AiController, 'transcribe'])
         router.get('ai/graph/visualize', [AiController, 'visualizeGraph'])