Bp base shell steps v0.2 by sandy724 · Pull Request #8 · OT-BUILDPIPER-MARKETPLACE/BP-TRIVY-STEP

sandy724 · 2022-11-08T11:45:47Z

No description provided.

github-actions · 2022-11-08T11:49:32Z

@@ -1,5 +1,5 @@
 #!/bin/bash
-source functions.sh
+source functions/functions.sh


📝 [shellcheck] _{reported by reviewdog 🐶}
Not following: functions/functions.sh: openBinaryFile: does not exist (No such file or directory) SC1091

…ble at /opt/buildpiper/shell-functions/

github-actions · 2022-11-08T12:11:52Z

@@ -1,5 +1,6 @@
 #!/bin/bash
-source functions.sh
+source /opt/buildpiper/shell-functions/functions.sh


📝 [shellcheck] _{reported by reviewdog 🐶}
Not following: /opt/buildpiper/shell-functions/functions.sh: openBinaryFile: does not exist (No such file or directory) SC1091

github-actions · 2022-11-08T12:11:52Z

 #!/bin/bash
-source functions.sh
+source /opt/buildpiper/shell-functions/functions.sh
+source /opt/buildpiper/shell-functions/log-functions.sh


📝 [shellcheck] _{reported by reviewdog 🐶}
Not following: /opt/buildpiper/shell-functions/log-functions.sh: openBinaryFile: does not exist (No such file or directory) SC1091

github-actions · 2022-11-08T12:11:52Z

+source /opt/buildpiper/shell-functions/functions.sh
+source /opt/buildpiper/shell-functions/log-functions.sh

 cd ${WORKSPACE}/${CODEBASE_DIR}


⚠️ [shellcheck] _{reported by reviewdog 🐶}
Use 'cd ... || exit' or 'cd ... || return' in case cd fails. SC2164

github-actions · 2022-11-08T12:11:53Z

+source /opt/buildpiper/shell-functions/functions.sh
+source /opt/buildpiper/shell-functions/log-functions.sh

 cd ${WORKSPACE}/${CODEBASE_DIR}


📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

github-actions · 2022-11-08T12:11:53Z

+source /opt/buildpiper/shell-functions/functions.sh
+source /opt/buildpiper/shell-functions/log-functions.sh

 cd ${WORKSPACE}/${CODEBASE_DIR}


📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

github-actions · 2022-11-08T12:11:53Z

@@ -1,5 +1,6 @@
 #!/bin/bash
-source functions.sh
+source /opt/buildpiper/shell-functions/functions.sh


📝 [shellcheck] _{reported by reviewdog 🐶}
Not following: /opt/buildpiper/shell-functions/functions.sh: openBinaryFile: does not exist (No such file or directory) SC1091

github-actions · 2022-11-08T12:11:53Z

 #!/bin/bash
-source functions.sh
+source /opt/buildpiper/shell-functions/functions.sh
+source /opt/buildpiper/shell-functions/log-functions.sh


📝 [shellcheck] _{reported by reviewdog 🐶}
Not following: /opt/buildpiper/shell-functions/log-functions.sh: openBinaryFile: does not exist (No such file or directory) SC1091

github-actions · 2022-11-08T12:11:53Z

+source /opt/buildpiper/shell-functions/functions.sh
+source /opt/buildpiper/shell-functions/log-functions.sh

 cd ${WORKSPACE}/${CODEBASE_DIR}


⚠️ [shellcheck] _{reported by reviewdog 🐶}
Use 'cd ... || exit' or 'cd ... || return' in case cd fails. SC2164

github-actions · 2022-11-08T12:11:53Z

+source /opt/buildpiper/shell-functions/functions.sh
+source /opt/buildpiper/shell-functions/log-functions.sh

 cd ${WORKSPACE}/${CODEBASE_DIR}


📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

github-actions · 2022-11-08T12:11:54Z

+source /opt/buildpiper/shell-functions/functions.sh
+source /opt/buildpiper/shell-functions/log-functions.sh

 cd ${WORKSPACE}/${CODEBASE_DIR}


📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

github-actions · 2022-11-08T12:11:57Z

+source /opt/buildpiper/shell-functions/functions.sh
+source /opt/buildpiper/shell-functions/log-functions.sh

 cd ${WORKSPACE}/${CODEBASE_DIR}


[shellcheck (suggestion)] _{reported by reviewdog 🐶}

Suggested change

cd ${WORKSPACE}/${CODEBASE_DIR}

cd "${WORKSPACE}"/"${CODEBASE_DIR}" || exit

github-actions · 2022-11-08T13:02:14Z

-    trivy image -q --severity ${SCAN_SEVERITY} --exit-code 1 ${FORMAT_ARG} ${OUTPUT_ARG} ${IMAGE_NAME}:${IMAGE_TAG} 
-    STATUS=`echo $?`
+    trivy image -q --severity "${SCAN_SEVERITY}" --exit-code 1 "${FORMAT_ARG}" "${OUTPUT_ARG}" "${IMAGE_NAME}":"${IMAGE_TAG}" 
+    STATUS=$(echo $?)


[shellcheck] _{reported by reviewdog 🐶}
Useless echo? Instead of 'cmd $(echo foo)', just use 'cmd foo'. SC2116

github-actions · 2022-11-08T13:02:14Z

+    STATUS=$(echo $?)
 fi

 if [ $STATUS -eq 0 ]


📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

github-actions · 2022-11-08T13:16:13Z

    logInfoMessage "trivy image -q --severity ${SCAN_SEVERITY} --exit-code 1 ${FORMAT_ARG} ${OUTPUT_ARG} ${IMAGE_NAME}:${IMAGE_TAG}"
-    trivy image -q --severity ${SCAN_SEVERITY} --exit-code 1 ${FORMAT_ARG} ${OUTPUT_ARG} ${IMAGE_NAME}:${IMAGE_TAG} 
-    STATUS=`echo $?`
+    trivy image -q --severity "${SCAN_SEVERITY}" --exit-code 1 ${FORMAT_ARG} "${OUTPUT_ARG}" "${IMAGE_NAME}":"${IMAGE_TAG}" 


📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

github-actions · 2022-11-08T13:18:00Z

    logInfoMessage "trivy image -q --severity ${SCAN_SEVERITY} --exit-code 1 ${FORMAT_ARG} ${OUTPUT_ARG} ${IMAGE_NAME}:${IMAGE_TAG}"
-    trivy image -q --severity ${SCAN_SEVERITY} --exit-code 1 ${FORMAT_ARG} ${OUTPUT_ARG} ${IMAGE_NAME}:${IMAGE_TAG} 
-    STATUS=`echo $?`
+    STATUS=$(trivy image -q --severity "${SCAN_SEVERITY}" --exit-code 1 ${FORMAT_ARG} "${OUTPUT_ARG}" "${IMAGE_NAME}":"${IMAGE_TAG}")


📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

sandy724 added 3 commits November 8, 2022 16:40

Updated dependency for base shell steps to 0.2 version

2e5e85d

moved submodule to v0.2 tag

466f6ea

Updated the location of base shell steps functions

c1a2b48

github-actions Bot reviewed Nov 8, 2022

View reviewed changes

Following the philosophy of convention, all helper scripts are availa…

2b62a4b

…ble at /opt/buildpiper/shell-functions/

github-actions Bot reviewed Nov 8, 2022

View reviewed changes

sandy724 added 4 commits November 8, 2022 18:13

Update readme with the details how to leverage submodule

f63730a

Updated the submodule as per v0.2

bcaa36d

Done the suggested changes as per shellcheck

6ca866c

Done the changes as suggested by shellchecker

a195fc0

github-actions Bot reviewed Nov 8, 2022

View reviewed changes

sandy724 added 3 commits November 8, 2022 18:34

Done the changes as suggested by shellchecker

b74c946

Reverting the changes for a while

e40ef39

Reverting the changes for a while

7d9287c

github-actions Bot reviewed Nov 8, 2022

View reviewed changes

removing echo 0 as suggested by shellchecker

a64c7f5

github-actions Bot reviewed Nov 8, 2022

View reviewed changes

Reverting the changes for a while

9b36884

	cd ${WORKSPACE}/${CODEBASE_DIR}
	cd "${WORKSPACE}"/"${CODEBASE_DIR}" \|\| exit

Conversation

sandy724 commented Nov 8, 2022

Uh oh!

github-actions Bot Nov 8, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Nov 8, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Nov 8, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Nov 8, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Nov 8, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Nov 8, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Nov 8, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Nov 8, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Nov 8, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Nov 8, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Nov 8, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Nov 8, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Nov 8, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Nov 8, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Nov 8, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Nov 8, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant