Merge pull request #80 from thelok/patch-2

Fix a bug where all groups/campaigns are returned from case insensitive search of `get_group_by_alias`/`get_campaign_by_alias`

Author: Cyb3rWard0g

attackcti/attack_api.py

@@ -1558,8 +1558,8 @@ def get_campaign_by_alias(self, alias: str, case: bool = True, stix_format: bool
             all_campaigns_list = list()
             for campaign in all_campaigns:
                 if "aliases" in campaign.keys():
-                    for alias in campaign['aliases']:
-                        if alias.lower() in alias.lower():
+                    for campaign_alias in campaign['aliases']:
+                        if alias.lower() in campaign_alias.lower():
                             all_campaigns_list.append(campaign)
         else:
             filter_objects = [
@@ -1592,8 +1592,8 @@ def get_group_by_alias(self, alias: str, case: bool = True, stix_format: bool =
             all_groups_list = list()
             for group in all_groups:
                 if "aliases" in group.keys():
-                    for alias in group['aliases']:
-                        if alias.lower() in alias.lower():
+                    for group_alias in group['aliases']:
+                        if alias.lower() in group_alias.lower():
                             all_groups_list.append(group)
         else:
             filter_objects = [