Skip to content

Commit fec964a

Browse files
fix(scripts): remove dead sonar-report dep and re-enable container cleanup
Closes #187. The jq ARG_MAX overflow was fixed in 32933c4 by replacing shell-based result aggregation with SonarReport.java. This commit removes leftover artifacts: the sonar-report tool check that blocks script execution despite no longer being used, and uncomments docker stop so the SonarQube container is properly cleaned up after a run.
1 parent b7b159c commit fec964a

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

scripts/runSonarQube.sh

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,6 @@ requireCommand curl
1313
requireCommand docker
1414
requireCommand jq
1515

16-
if ! command -v "sonar-report" &> /dev/null; then
17-
echo "sonar-report is required. Please install it via https://github.com/soprasteria/sonar-report and then try again."
18-
exit 1
19-
fi
20-
2116
# Check for install/updates at https://github.com/SonarSource/sonarqube
2217

2318
container_name="sonarqube-benchmark"
@@ -91,4 +86,4 @@ mvn exec:java -Dexec.mainClass="org.owasp.benchmark.report.sonarqube.SonarReport
9186

9287
echo "Shutting down SonarQube..."
9388

94-
#docker stop "$container_name"
89+
docker stop "$container_name"

0 commit comments

Comments
 (0)