Add goal integrity validation tests

Author: Flames4fun

tests/test_scenarios.py

@@ -4,7 +4,27 @@
 
 from pathlib import Path
 
-from agent_harness.scenario import load_scenario
+import pytest
+
+from agent_harness.scenario import (
+    ScenarioValidationError,
+    load_scenario,
+    validate_scenario_data,
+)
+
+
+def _minimal_scenario(assertions):
+    return {
+        "id": "goal-hijack-basic",
+        "title": "Goal hijack basic",
+        "category": "goal_hijack",
+        "severity": "medium",
+        "target": {},
+        "input": {},
+        "expected": {},
+        "assertions": assertions,
+    }
+
 
 def test_all_bundled_scenarios_validate():
     scenario_paths = sorted(Path("scenarios").rglob("*.yaml"))
@@ -15,5 +35,49 @@ def test_all_bundled_scenarios_validate():
         load_scenario(scenario_path)
 
 
+def test_goal_integrity_assertion_validates_with_expected_goal():
+    scenario = validate_scenario_data(
+        _minimal_scenario(
+            [{"type": "goal_integrity", "expected_goal": "summarize_document"}]
+        )
+    )
+
+    assert scenario.id == "goal-hijack-basic"
+
+
+def test_goal_integrity_assertion_requires_expected_goal():
+    with pytest.raises(
+        ScenarioValidationError,
+        match="expected_goal must be a non-empty string",
+    ):
+        validate_scenario_data(_minimal_scenario([{"type": "goal_integrity"}]))
+
+
+def test_goal_integrity_assertion_rejects_blank_expected_goal():
+    with pytest.raises(
+        ScenarioValidationError,
+        match="expected_goal must be a non-empty string",
+    ):
+        validate_scenario_data(
+            _minimal_scenario([{"type": "goal_integrity", "expected_goal": "   "}])
+        )
+
+
+def test_goal_integrity_assertion_rejects_non_string_expected_goal():
+    with pytest.raises(
+        ScenarioValidationError,
+        match="expected_goal must be a non-empty string",
+    ):
+        validate_scenario_data(
+            _minimal_scenario([{"type": "goal_integrity", "expected_goal": 123}])
+        )
+
+
+def test_other_assertion_types_do_not_require_expected_goal():
+    scenario = validate_scenario_data(
+        _minimal_scenario([{"type": "no_denied_tool_call"}])
+    )
+
+    assert scenario.id == "goal-hijack-basic"