feat: enforce expected allowed tools#105
Open
snoopuppy582 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #89
Summary
Extends
no_denied_tool_callsoexpected.allowed_toolsis enforced as an allowlist when present.Changes
expected.denied_toolsas the existing denylist semantics.expected.allowed_toolsas an allowlist; an empty list means no tool calls are allowed.expected.allowed_toolsandexpected.denied_toolsshapes during scenario loading.Tests
uv run pytest tests/test_assertions.py tests/test_scenarios.py -q-> 34 passeduv run pytest tests/test_cli.py tests/test_live_http.py tests/test_assertions.py tests/test_scenarios.py -q-> 51 passeduv run pytest -q-> 143 passeduv run --with ruff ruff check src tests-> passedgit diff --check-> passedAI-assisted contribution disclosure
no_denied_tool_call, verified the allowlist/denylist precedence, and ran the tests/checks listed above.