feat: add SARIF 2.1.0 output for code scanning integrations#153
Open
omobolajiadeyan wants to merge 5 commits into
Open
feat: add SARIF 2.1.0 output for code scanning integrations#153omobolajiadeyan wants to merge 5 commits into
omobolajiadeyan wants to merge 5 commits into
Conversation
Contributor
Author
|
Follow-up after the failed CI run: I fixed the Ruff import-order failure in commit b3fb2ef by sorting the new SARIF CLI import.\n\nCurrent PR status:\n- lint: passing\n- test: passing\n- Run security regression scenarios: passing\n\nLocal checks also passed for:\n- python -m ruff check src tests\n- python -m agent_harness.cli validate scenarios\n\nThe change remains scoped to SARIF 2.1.0 output and GitHub Code Scanning integration support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #82.
Adds
--sarif-out <path>toagent-harness runso CI pipelines can surfacesecurity regression failures through GitHub Code Scanning and other SARIF-aware
dashboards.
Changes
src/agent_harness/sarif.py— convertsHarnessResultto SARIF 2.1.0--sarif-outflag to therunsubcommand incli.py--sarif-outand GitHub Code Scanning upload indocs/ci-github-actions.mdDesign notes
failanderrorassertions produce SARIF results.passandnot_runare omitted because SARIF results represent findings, not confirmations.agent-harness/<assertion-id>. Assertion IDs come from scenario definitions and are stable across runs.failmaps to SARIF levelerror;errormaps towarning.locationsis an empty array — there are no source locations because assertions evaluate runtime agent behaviour, not static code.scenario_id,mode, andoverall_resultas run-level properties for downstream consumers.Validation
Example CI step