Create Bot_Management_and_Anti-Automation_Cheat_Sheet.md#2148
Merged
jmanico merged 3 commits intoOWASP:masterfrom May 6, 2026
Merged
Create Bot_Management_and_Anti-Automation_Cheat_Sheet.md#2148jmanico merged 3 commits intoOWASP:masterfrom
jmanico merged 3 commits intoOWASP:masterfrom
Conversation
mackowski
reviewed
May 5, 2026
| windowMs: 15 * 60 * 1000, // 15 minutes | ||
| max: 5, // 5 attempts per key | ||
| keyGenerator: (req) => | ||
| `login:${req.ip}:${req.body?.username ?? 'anon'}`, |
Collaborator
There was a problem hiding this comment.
This produces one 5-attempt bucket per (IP, username) pair, which means a single IP can try 5 attempts against an unlimited number of usernames before any limit fires right?
Member
I suggest you drop the code and just describe the control, please. Also:
|
Contributor
Author
|
Thanks @mackowski and @jmanico for the careful review Rate limiter: I've removed the code block entirely as suggested Pushed the latest commit. |
mackowski
approved these changes
May 6, 2026
jmanico
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains new CS related to the Bot management.
Bots and AI traffics increased hugely. That's why I thought that It would be great to have single, actionable doc.
Please make sure that for your contribution:
[TEXT](URL)This PR fixes issue #2147 .
AI Tool Usage Disclosure (required for all PRs)
Please select one of the following options:
the contents and I affirm the results. The LLM used is
[llm name and version]and the prompt used is
[your prompt here]. [Feel free to add more details if needed]Thank you again for your contribution 😃