Commit 977cec6
week_3: address CodeRabbit findings on #937
- config_loader_test: assert retriever_backend in both the defaults and the
override tests (was the only LibrarianConfig field left unchecked).
- __init__.py: refresh the stale 'No linking logic yet' scope note to reflect
W1 contracts + W2 C.0 boundary + W3 C.1 retriever.
Other #937 CodeRabbit findings were already addressed on this branch
(knowledge_source model_validate_json error handling, schemas AnyUrl/datetime
fields, section_validator assert->if, test_config_is_frozen isolation +
FrozenInstanceError, dataset_test subprocess timeout, build_golden_dataset
unused loop var).1 parent ae94de8 commit 977cec6
2 files changed
Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
| |||
27 | 28 | | |
28 | 29 | | |
29 | 30 | | |
| 31 | + | |
30 | 32 | | |
31 | 33 | | |
32 | 34 | | |
| |||
39 | 41 | | |
40 | 42 | | |
41 | 43 | | |
| 44 | + | |
42 | 45 | | |
43 | 46 | | |
44 | 47 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
17 | 19 | | |
18 | 20 | | |
19 | 21 | | |
| |||
0 commit comments