Skip to content

Commit bac59d3

Browse files
Expose OpenCRE in Gap Analysis standards list (#891)
* Add OpenCRE as a map analysis resource * Preserve multiple OpenCRE map analysis overlaps * Clean issue #469 web_main.py * Add direct-only OpenCRE map analysis * Fix OpenCRE map analysis hover payload * Add OpenCRE as a map analysis resource * Preserve multiple OpenCRE map analysis overlaps * Add direct-only OpenCRE map analysis * Fix OpenCRE map analysis hover payload * Enhance map analysis by enforcing two standards input and improving Redis fallback handling * Fix missing newline at end of file in web_main.py * Enhance gap analysis standards to include OpenCRE and ensure proper eligibility filtering --------- Signed-off-by: Bornunique911 <69379200+Bornunique911@users.noreply.github.com>
1 parent 361b741 commit bac59d3

2 files changed

Lines changed: 8 additions & 3 deletions

File tree

application/tests/web_main_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -970,7 +970,7 @@ def test_ga_standards_filters_non_eligible(
970970
headers={"Content-Type": "application/json"},
971971
)
972972
self.assertEqual(200, response.status_code)
973-
self.assertEqual(["ASVS", "CAPEC"], json.loads(response.data))
973+
self.assertEqual(["ASVS", "CAPEC", "OpenCRE"], json.loads(response.data))
974974

975975
def test_gap_analysis_weak_links_no_cache(self) -> None:
976976
with self.app.test_client() as client:

application/web/web_main.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -603,9 +603,14 @@ def ga_standards() -> Any:
603603
posthog.capture("ga_standards", "")
604604

605605
database = db.Node_collection()
606-
standards = database.standards()
606+
standards = list(database.standards())
607+
if OPENCRE_STANDARD_NAME not in standards:
608+
standards.append(OPENCRE_STANDARD_NAME)
607609
eligible = [
608-
s for s in standards if cre_main.resource_name_ga_eligible_in_db(database, s)
610+
s
611+
for s in standards
612+
if s == OPENCRE_STANDARD_NAME
613+
or cre_main.resource_name_ga_eligible_in_db(database, s)
609614
]
610615
return sorted(eligible)
611616

0 commit comments

Comments
 (0)