fix: address CodeRabbit review on /api/capabilities

Use patch.dict for CRE_ENABLE_MYOPENCRE in tests so any preexisting value is restored and tests aren't order-dependent. Add docstrings to is_myopencre_enabled, get_capabilities, and the capabilities tests to satisfy docstring coverage.

Author: skypank-coder

application/feature_flags.py

@@ -19,4 +19,5 @@ def is_health_endpoint_enabled() -> bool:
 
 
 def is_myopencre_enabled() -> bool:
+    """Return True when the MyOpenCRE feature is enabled via CRE_ENABLE_MYOPENCRE."""
     return os.getenv("CRE_ENABLE_MYOPENCRE", "").strip().lower() in TRUE_VALUES

application/tests/web_main_test.py

@@ -1527,29 +1527,31 @@ def test_health_db_unreachable_returns_503(self) -> None:
             os.environ.pop("CRE_ENABLE_HEALTH", None)
 
     def test_capabilities_endpoint_returns_myopencre_key(self) -> None:
-        os.environ.pop("CRE_ENABLE_MYOPENCRE", None)
-        with self.app.test_client() as client:
-            response = client.get("/api/capabilities")
-            self.assertEqual(200, response.status_code)
-            body = json.loads(response.data.decode())
-            self.assertIn("myopencre", body)
-            self.assertIsInstance(body["myopencre"], bool)
+        """GET /api/capabilities returns 200 with a boolean myopencre key."""
+        with patch.dict(os.environ, {}, clear=False):
+            os.environ.pop("CRE_ENABLE_MYOPENCRE", None)
+            with self.app.test_client() as client:
+                response = client.get("/api/capabilities")
+                self.assertEqual(200, response.status_code)
+                body = json.loads(response.data.decode())
+                self.assertIn("myopencre", body)
+                self.assertIsInstance(body["myopencre"], bool)
 
     def test_capabilities_myopencre_false_by_default(self) -> None:
-        os.environ.pop("CRE_ENABLE_MYOPENCRE", None)
-        with self.app.test_client() as client:
-            response = client.get("/api/capabilities")
-            self.assertEqual(200, response.status_code)
-            body = json.loads(response.data.decode())
-            self.assertFalse(body["myopencre"])
+        """myopencre is False when CRE_ENABLE_MYOPENCRE is unset."""
+        with patch.dict(os.environ, {}, clear=False):
+            os.environ.pop("CRE_ENABLE_MYOPENCRE", None)
+            with self.app.test_client() as client:
+                response = client.get("/api/capabilities")
+                self.assertEqual(200, response.status_code)
+                body = json.loads(response.data.decode())
+                self.assertFalse(body["myopencre"])
 
     def test_capabilities_myopencre_true_when_flag_set(self) -> None:
-        os.environ["CRE_ENABLE_MYOPENCRE"] = "1"
-        try:
+        """myopencre is True when CRE_ENABLE_MYOPENCRE is set to a truthy value."""
+        with patch.dict(os.environ, {"CRE_ENABLE_MYOPENCRE": "1"}, clear=False):
             with self.app.test_client() as client:
                 response = client.get("/api/capabilities")
                 self.assertEqual(200, response.status_code)
                 body = json.loads(response.data.decode())
                 self.assertTrue(body["myopencre"])
-        finally:
-            os.environ.pop("CRE_ENABLE_MYOPENCRE", None)

application/web/web_main.py

@@ -1202,6 +1202,7 @@ def get_config() -> Any:
 
 @app.route("/api/capabilities", methods=["GET"])
 def get_capabilities() -> Any:
+    """Expose frontend feature capabilities, e.g. whether MyOpenCRE is enabled."""
     return jsonify({"myopencre": is_myopencre_enabled()})