-
Notifications
You must be signed in to change notification settings - Fork 116
GSOC-Week1-Module_A #920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ParthAggarwal16
wants to merge
16
commits into
OWASP:main
Choose a base branch
from
ParthAggarwal16:week_1-2-harvester-validation-and-docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
GSOC-Week1-Module_A #920
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
aed4fe6
feat(harvester): implement repository configuration loader
ParthAggarwal16 f370f73
fix(harvester): address CodeRabbit validation feedback
ParthAggarwal16 9478e54
feat(harvester): add repository config loader and validation
ParthAggarwal16 43fb6cb
addressing coderabbit
ParthAggarwal16 b962246
addressing coderabbit again
ParthAggarwal16 b556308
Add repository validation rules and fixtures
ParthAggarwal16 fc4b583
normalize repository ids during validation
ParthAggarwal16 713f99d
Refine harvester validation exports and YAML fixtures
ParthAggarwal16 c7ecbf0
removed stable dev comments
ParthAggarwal16 0be6df8
Add validator success test and clean exports
ParthAggarwal16 f96ff3d
Merge branch 'main' into week_1-2-harvester-validation-and-docs
ParthAggarwal16 c728fed
test(harvester): align tests with project conventions
ParthAggarwal16 d4e7731
chore: ignore Claude and Cursor project files
ParthAggarwal16 f11f869
refactor(harvester): address review feedback
ParthAggarwal16 74e285e
test(harvester): strengthen configuration validation coverage
ParthAggarwal16 61e77b1
test(harvester): add case-insensitive repository validation tests
ParthAggarwal16 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| """ | ||
| tests for Module A configuration layer (empty for now) | ||
| """ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,122 @@ | ||
| from pathlib import Path | ||
| import unittest | ||
|
|
||
| from application.utils.harvester.config_loader import ( | ||
| ConfigLoaderError, | ||
| ConfigFileNotFoundError, | ||
| load_repo_config, | ||
| ) | ||
|
|
||
| FIXTURES_DIR = Path(__file__).parent / "fixtures" | ||
|
|
||
|
|
||
| class ConfigLoaderTests(unittest.TestCase): | ||
| def test_load_valid_config(self): | ||
| config_path = FIXTURES_DIR / "valid_repos.yaml" | ||
|
|
||
| config = load_repo_config(config_path) | ||
|
|
||
| self.assertEqual(len(config.repositories), 1) | ||
|
|
||
| repo = config.repositories[0] | ||
|
|
||
| self.assertEqual(repo.id, "owasp-asvs") | ||
| self.assertEqual(repo.owner, "OWASP") | ||
| self.assertEqual(repo.repo, "ASVS") | ||
|
|
||
| def test_missing_repository_id(self): | ||
| config_path = FIXTURES_DIR / "invalid_missing_id.yaml" | ||
|
|
||
| with self.assertRaises(ConfigLoaderError): | ||
| load_repo_config(config_path) | ||
|
|
||
| def test_invalid_chunk_size(self): | ||
| config_path = FIXTURES_DIR / "invalid_chunk_size.yaml" | ||
|
|
||
| with self.assertRaisesRegex(ConfigLoaderError, "max_tokens"): | ||
| load_repo_config(config_path) | ||
|
|
||
| def test_invalid_yaml_syntax(self): | ||
| config_path = FIXTURES_DIR / "invalid_yaml.yaml" | ||
|
|
||
| with self.assertRaises(ConfigLoaderError): | ||
| load_repo_config(config_path) | ||
|
|
||
| def test_missing_config_file(self): | ||
| with self.assertRaises(ConfigFileNotFoundError): | ||
| load_repo_config("does_not_exist.yaml") | ||
|
|
||
| def test_invalid_polling_interval(self): | ||
| config_path = FIXTURES_DIR / "invalid_polling_interval.yaml" | ||
|
|
||
| with self.assertRaises(ConfigLoaderError): | ||
| load_repo_config(config_path) | ||
|
|
||
| def test_empty_include_paths(self): | ||
| config_path = FIXTURES_DIR / "empty_include_paths.yaml" | ||
|
|
||
| with self.assertRaises(ConfigLoaderError): | ||
| load_repo_config(config_path) | ||
|
|
||
| def test_whitespace_only_repository_id(self): | ||
| config_path = FIXTURES_DIR / "whitespace_id.yaml" | ||
|
|
||
| with self.assertRaises(ConfigLoaderError): | ||
| load_repo_config(config_path) | ||
|
|
||
| def test_whitespace_only_owner(self): | ||
| config_path = FIXTURES_DIR / "whitespace_owner.yaml" | ||
|
|
||
| with self.assertRaises(ConfigLoaderError): | ||
| load_repo_config(config_path) | ||
|
|
||
| def test_whitespace_only_repo(self): | ||
| config_path = FIXTURES_DIR / "whitespace_repo.yaml" | ||
|
|
||
| with self.assertRaises(ConfigLoaderError): | ||
| load_repo_config(config_path) | ||
|
|
||
| def test_whitespace_only_branch(self): | ||
| config_path = FIXTURES_DIR / "whitespace_branch.yaml" | ||
|
|
||
| with self.assertRaises(ConfigLoaderError): | ||
| load_repo_config(config_path) | ||
|
|
||
| def test_overlap_tokens_must_be_less_than_max_tokens(self): | ||
| config_path = FIXTURES_DIR / "invalid_overlap_tokens.yaml" | ||
|
|
||
| with self.assertRaisesRegex(ConfigLoaderError, "overlap_tokens"): | ||
| load_repo_config(config_path) | ||
|
|
||
| def test_load_packaged_repos_yaml(self): | ||
| config_path = ( | ||
| Path(__file__).resolve().parents[2] / "utils" / "harvester" / "repos.yaml" | ||
| ) | ||
|
|
||
| config = load_repo_config(config_path) | ||
|
|
||
| self.assertEqual(len(config.repositories), 2) | ||
| self.assertEqual(config.repositories[0].id, "owasp-asvs") | ||
| self.assertEqual(config.repositories[1].id, "owasp-cheatsheets") | ||
|
|
||
| def test_empty_owner(self): | ||
| config_path = FIXTURES_DIR / "empty_owner.yaml" | ||
|
|
||
| with self.assertRaises(ConfigLoaderError): | ||
| load_repo_config(config_path) | ||
|
|
||
| def test_invalid_chunking_strategy(self): | ||
| config_path = FIXTURES_DIR / "invalid_chunking_strategy.yaml" | ||
|
|
||
| with self.assertRaises(ConfigLoaderError): | ||
| load_repo_config(config_path) | ||
|
|
||
| def test_invalid_polling_mode(self): | ||
| config_path = FIXTURES_DIR / "invalid_polling_mode.yaml" | ||
|
|
||
| with self.assertRaises(ConfigLoaderError): | ||
| load_repo_config(config_path) | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| unittest.main() | ||
22 changes: 22 additions & 0 deletions
22
application/tests/harvester_test/fixtures/duplicate_include_paths.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| repositories: | ||
| - id: duplicate-includes | ||
| type: github | ||
| enabled: true | ||
|
|
||
| owner: OWASP | ||
| repo: ASVS | ||
| branch: master | ||
|
|
||
| paths: | ||
| include: | ||
| - "docs/**/*.md" | ||
| - "docs/**/*.md" | ||
|
|
||
| chunking: | ||
| strategy: markdown_heading | ||
| max_tokens: 1200 | ||
| overlap_tokens: 100 | ||
|
|
||
| polling: | ||
| mode: incremental | ||
| interval_minutes: 60 |
34 changes: 34 additions & 0 deletions
34
application/tests/harvester_test/fixtures/duplicate_repo_ids.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| repositories: | ||
| - id: asvs | ||
| type: github | ||
| owner: OWASP | ||
| repo: ASVS | ||
|
|
||
| paths: | ||
| include: | ||
| - "4.0/en/**/*.md" | ||
|
|
||
| chunking: | ||
| strategy: markdown_heading | ||
| max_tokens: 1200 | ||
|
|
||
| polling: | ||
| mode: incremental | ||
| interval_minutes: 60 | ||
|
|
||
| - id: asvs | ||
| type: github | ||
| owner: OWASP | ||
| repo: CheatSheetSeries | ||
|
|
||
| paths: | ||
| include: | ||
| - "cheatsheets/**/*.md" | ||
|
|
||
| chunking: | ||
| strategy: markdown_heading | ||
| max_tokens: 1200 | ||
|
|
||
| polling: | ||
| mode: incremental | ||
| interval_minutes: 60 |
34 changes: 34 additions & 0 deletions
34
application/tests/harvester_test/fixtures/duplicate_repo_ids_case.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| repositories: | ||
| - id: asvs | ||
| type: github | ||
| owner: OWASP | ||
| repo: ASVS | ||
|
|
||
| paths: | ||
| include: | ||
| - "4.0/en/**/*.md" | ||
|
|
||
| chunking: | ||
| strategy: markdown_heading | ||
| max_tokens: 1200 | ||
|
|
||
| polling: | ||
| mode: incremental | ||
| interval_minutes: 60 | ||
|
|
||
| - id: ASVS | ||
| type: github | ||
| owner: OWASP | ||
| repo: CheatSheetSeries | ||
|
|
||
| paths: | ||
| include: | ||
| - "cheatsheets/**/*.md" | ||
|
|
||
| chunking: | ||
| strategy: markdown_heading | ||
| max_tokens: 1200 | ||
|
|
||
| polling: | ||
| mode: incremental | ||
| interval_minutes: 60 |
34 changes: 34 additions & 0 deletions
34
application/tests/harvester_test/fixtures/duplicate_repositories.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| repositories: | ||
| - id: asvs-1 | ||
| type: github | ||
| owner: OWASP | ||
| repo: ASVS | ||
|
|
||
| paths: | ||
| include: | ||
| - "4.0/en/**/*.md" | ||
|
|
||
| chunking: | ||
| strategy: markdown_heading | ||
| max_tokens: 1200 | ||
|
|
||
| polling: | ||
| mode: incremental | ||
| interval_minutes: 60 | ||
|
|
||
| - id: asvs-2 | ||
| type: github | ||
| owner: OWASP | ||
| repo: ASVS | ||
|
|
||
| paths: | ||
| include: | ||
| - "4.0/en/**/*.md" | ||
|
|
||
| chunking: | ||
| strategy: markdown_heading | ||
| max_tokens: 1200 | ||
|
|
||
| polling: | ||
| mode: incremental | ||
| interval_minutes: 60 |
34 changes: 34 additions & 0 deletions
34
application/tests/harvester_test/fixtures/duplicate_repositories_case.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| repositories: | ||
| - id: asvs-1 | ||
| type: github | ||
| owner: OWASP | ||
| repo: ASVS | ||
|
|
||
| paths: | ||
| include: | ||
| - "4.0/en/**/*.md" | ||
|
|
||
| chunking: | ||
| strategy: markdown_heading | ||
| max_tokens: 1200 | ||
|
|
||
| polling: | ||
| mode: incremental | ||
| interval_minutes: 60 | ||
|
|
||
| - id: asvs-2 | ||
| type: github | ||
| owner: owasp | ||
| repo: asvs | ||
|
|
||
| paths: | ||
| include: | ||
| - "4.0/en/**/*.md" | ||
|
|
||
| chunking: | ||
| strategy: markdown_heading | ||
| max_tokens: 1200 | ||
|
|
||
| polling: | ||
| mode: incremental | ||
| interval_minutes: 60 |
16 changes: 16 additions & 0 deletions
16
application/tests/harvester_test/fixtures/empty_include_paths.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| repositories: | ||
| - id: asvs | ||
| type: github | ||
| owner: OWASP | ||
| repo: ASVS | ||
|
|
||
| paths: | ||
| include: [] | ||
|
|
||
| chunking: | ||
| strategy: markdown_heading | ||
| max_tokens: 1200 | ||
|
|
||
| polling: | ||
| mode: incremental | ||
| interval_minutes: 60 |
21 changes: 21 additions & 0 deletions
21
application/tests/harvester_test/fixtures/empty_owner.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| repositories: | ||
| - id: empty-owner | ||
| type: github | ||
| enabled: true | ||
|
|
||
| owner: "" | ||
| repo: ASVS | ||
| branch: master | ||
|
|
||
| paths: | ||
| include: | ||
| - "docs/**/*.md" | ||
|
|
||
| chunking: | ||
| strategy: markdown_heading | ||
| max_tokens: 1200 | ||
| overlap_tokens: 100 | ||
|
|
||
| polling: | ||
| mode: incremental | ||
| interval_minutes: 60 |
18 changes: 18 additions & 0 deletions
18
application/tests/harvester_test/fixtures/invalid_chunk_size.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| repositories: | ||
| - id: owasp-asvs | ||
|
|
||
| type: github | ||
| owner: OWASP | ||
| repo: ASVS | ||
|
|
||
| paths: | ||
| include: | ||
| - "4.0/en/**/*.md" | ||
|
|
||
| chunking: | ||
| strategy: markdown_heading | ||
| max_tokens: 0 | ||
|
|
||
| polling: | ||
| mode: incremental | ||
| interval_minutes: 60 |
21 changes: 21 additions & 0 deletions
21
application/tests/harvester_test/fixtures/invalid_chunking_strategy.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| repositories: | ||
| - id: invalid-strategy | ||
| type: github | ||
| enabled: true | ||
|
|
||
| owner: OWASP | ||
| repo: ASVS | ||
| branch: master | ||
|
|
||
| paths: | ||
| include: | ||
| - "docs/**/*.md" | ||
|
|
||
| chunking: | ||
| strategy: invalid_strategy | ||
| max_tokens: 1200 | ||
| overlap_tokens: 100 | ||
|
|
||
| polling: | ||
| mode: incremental | ||
| interval_minutes: 60 |
17 changes: 17 additions & 0 deletions
17
application/tests/harvester_test/fixtures/invalid_missing_id.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| repositories: | ||
| - type: github | ||
|
|
||
| owner: OWASP | ||
| repo: ASVS | ||
|
|
||
| paths: | ||
| include: | ||
| - "4.0/en/**/*.md" | ||
|
|
||
| chunking: | ||
| strategy: markdown_heading | ||
| max_tokens: 1200 | ||
|
|
||
| polling: | ||
| mode: incremental | ||
| interval_minutes: 60 |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please extend this test class to exercise the validation paths represented by the existing but unused
empty_owner.yaml,invalid_chunking_strategy.yaml, andinvalid_polling_mode.yamlfixtures; each should callload_repo_config()and assertConfigLoaderError. Also add cases for whitespace-only repository fields andoverlap_tokens >= max_tokens, plus a success test loading the real packagedrepos.yaml. Inrepos_validator_test.py, add case-only duplicate IDs/repositories so the intendedcasefold()behavior is locked down.