Fix finding overrides wiping values copied from the threat#339
Open
NoodlesNZ wants to merge 1 commit into
Open
Fix finding overrides wiping values copied from the threat#339NoodlesNZ wants to merge 1 commit into
NoodlesNZ wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a finding matched an element override,
Finding.__init__merged in the fullmodel_dump()of the override. Since overrides backfill required fields with empty strings, an override that only set response or cvss would blank out the finding's description, severity, mitigations — and the finding id assigned byresolve().The merge now uses
model_dump(exclude_unset=True), and the constructor no longer records its backfilled placeholders in__pydantic_fields_set__, so only fields actually set on the override are applied.Extended
test_overridesto assert that threat-sourced fields and the finding id survive an override — it only checked the overridden fields before, which is how this slipped through.