Fix JSON round-trip: loads() couldn't read dumps() output#340
Open
NoodlesNZ wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JSON produced by
--jsoncouldn't be loaded back withpytm.loads(). The dump writes enums asstr(member)("Classification.SECRET")while the loader expected bare member names, it writes "inBoundary": null which the loader treated as a real reference, and it serializes derived state (findings, inputs/outputs, carriedBy) as name strings that blow up when passed into typed fields.Changes:
_missing_hook to the pytm enums so both "SECRET" and "Classification.SECRET" resolve. This covers every enum field in one place, including Pydantic validation on elements. The dump format itself is unchanged.check()/resolve()anyway — and ignores null boundary refs.Added
test_json_round_trip, which dumps a model with nested boundaries, classified data and a response flow, reloads it, and checks the relationships survive. Existing hand-written JSON fixtures still load as before.