Skip to content

feat(ci): implement new single-script e2e test workflow#972

Open
seershan wants to merge 233 commits into
OWASP:mainfrom
seershan:fix/ci-e2e-script
Open

feat(ci): implement new single-script e2e test workflow#972
seershan wants to merge 233 commits into
OWASP:mainfrom
seershan:fix/ci-e2e-script

Conversation

@seershan

Copy link
Copy Markdown

Thank you for submitting a pull request to the WrongSecrets Party!

What kind of changes does this PR include?

  • Fixes or refactors
  • A new feature

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added tests to ensure my change works (if applicable)
  • The PR passes pre-commit hooks and automated tests

This pull request adds a suite of Cypress End-to-End tests and a new GitHub Action to run them, fulfilling the requirements of issue #284. It also includes the necessary fixes to the deployment scripts and configuration to get the local and CI environments working.

This is a clean replacement for the previous pull request (#970).

Closes #284

Comment thread .github/workflows/e2e-tests.yml Outdated
- name: Install yq
run: sudo wget https://github.com/mikefarah/yq/releases/latest/download/yq_linux_amd64 -O /usr/bin/yq && sudo chmod +x /usr/bin/yq
- name: Run Deployment Script
run: ./build-and-deploy-minikube.sh

@commjoen commjoen Sep 12, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems it is still waiting here as the script will never end. Instead it might be better to run this in the background (e.g. ./build-and-deploy-minikube.sh & and then do a poll:

Suggested change
run: ./build-and-deploy-minikube.sh
run: |
./build-and-deploy-minikube.sh &
pause 10
kubectl wait --for=condition=ready pod -l app=wrongsecrets-balancer --timeout=2s

@commjoen

commjoen commented Oct 4, 2025

Copy link
Copy Markdown
Collaborator

Hi @seershan , it's been a while! Hope you are doing great!
Can you please have a look at the feedback and the failing checks? Feel free to DM me over slack if you are having trouble resolving the issues.

@seershan

seershan commented Oct 4, 2025

Copy link
Copy Markdown
Author

Hello @commjoen actually im out of station currently, I will start again by Tuesday.
Sorry for the delay.

@commjoen

commjoen commented Oct 4, 2025

Copy link
Copy Markdown
Collaborator

all good! Have a good time and will see the commits later 👍

@commjoen

Copy link
Copy Markdown
Collaborator

any updates on this good sir ;) ?

@commjoen

Copy link
Copy Markdown
Collaborator

Any updates on this @seershan ?

@seershan

Copy link
Copy Markdown
Author

Hi @commjoen,

Sorry for the long delay on this. I've been quite busy with personal commitments and only recently had the chance to get back to this PR.

I started debugging the workflow again and reproduced deployment-related issues locally. I found that the workflow was starting the deployment script in the background while simultaneously waiting for pods, so I've pushed a change to run the deployment script synchronously and am waiting for the CI checks to complete.

I'll investigate further based on the results of the new workflow run. Thanks for your patience.

Copilot AI and others added 19 commits June 15, 2026 12:39
…ixes

Co-authored-by: commjoen <1457214+commjoen@users.noreply.github.com>
Co-authored-by: commjoen <1457214+commjoen@users.noreply.github.com>
Co-authored-by: commjoen <1457214+commjoen@users.noreply.github.com>
Co-authored-by: commjoen <1457214+commjoen@users.noreply.github.com>
Co-authored-by: commjoen <1457214+commjoen@users.noreply.github.com>
Co-authored-by: commjoen <1457214+commjoen@users.noreply.github.com>
…cript 5.9.2 compatibility

Co-authored-by: commjoen <1457214+commjoen@users.noreply.github.com>
…nd enforce engines requirements

Co-authored-by: commjoen <1457214+commjoen@users.noreply.github.com>
Co-authored-by: commjoen <1457214+commjoen@users.noreply.github.com>
Co-authored-by: Jeroen Willemsen <jeroenwillemsen2001@gmail.com>
Bumps [axios](https://github.com/axios/axios) from 1.11.0 to 1.12.0.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](axios/axios@v1.11.0...v1.12.0)

---
updated-dependencies:
- dependency-name: axios
  dependency-version: 1.12.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
renovate Bot and others added 28 commits June 15, 2026 12:39
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.23 to 4.18.1.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.23...4.18.1)

---
updated-dependencies:
- dependency-name: lodash
  dependency-version: 4.18.1
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [axios](https://github.com/axios/axios) from 1.14.0 to 1.15.0.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](axios/axios@v1.14.0...v1.15.0)

---
updated-dependencies:
- dependency-name: axios
  dependency-version: 1.15.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [protobufjs](https://github.com/protobufjs/protobuf.js) from 7.5.4 to 7.5.5.
- [Release notes](https://github.com/protobufjs/protobuf.js/releases)
- [Changelog](https://github.com/protobufjs/protobuf.js/blob/master/CHANGELOG.md)
- [Commits](protobufjs/protobuf.js@protobufjs-v7.5.4...protobufjs-v7.5.5)

---
updated-dependencies:
- dependency-name: protobufjs
  dependency-version: 7.5.5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.11 to 1.16.0.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.11...v1.16.0)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-version: 1.16.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.11 to 1.16.0.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.11...v1.16.0)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-version: 1.16.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [fast-xml-parser](https://github.com/NaturalIntelligence/fast-xml-parser) from 5.5.7 to 5.7.1.
- [Release notes](https://github.com/NaturalIntelligence/fast-xml-parser/releases)
- [Changelog](https://github.com/NaturalIntelligence/fast-xml-parser/blob/master/CHANGELOG.md)
- [Commits](NaturalIntelligence/fast-xml-parser@v5.5.7...v5.7.1)

---
updated-dependencies:
- dependency-name: fast-xml-parser
  dependency-version: 5.7.1
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@seershan seershan force-pushed the fix/ci-e2e-script branch from 319dd9f to 93cff67 Compare June 15, 2026 07:10
@commjoen

Copy link
Copy Markdown
Collaborator

hi @seershan , it looks like the branch has quite a few merge conflicts, are you sure these need to be updated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create cypres test for full round trip (webtop &wrongsecrets)

3 participants