Fix outdated detector API usage in scanning modules#48
Open
kavya-seth-vns wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #44
Summary
This PR updates the scanning utilities to use the current detector API and resolves the runtime failures caused by outdated detector interface usage.
Changes
Replaced deprecated
detector.detect()calls withdetector.inspect().Updated
DetectionResultfield access to match the current API:detected→matchedUpdated the affected modules:
scan.pytools.pystreaming.pyrag.pyValidation
The issue was reproduced before the fix:
After applying the changes:
scan()executes successfully.scan_tool_output()executes successfully.StreamScanner.feed()executes successfully.scan_rag_input()executes successfully.Testing
Executed the full test suite:
Additionally, the following runtime checks were verified successfully:
scan("hello")scan_tool_output("hello")StreamScanner().feed("hello")scan_rag_input("hello")These changes align the scanning modules with the current
Detectorprotocol and eliminate theAttributeErrorcaused by calls to the removeddetect()method.