app: improved feerecipient behavior (#4491)

* app: improved feerecipient behavior

Author: pinebit

app/builderregistration.go

@@ -226,19 +226,19 @@ func (s *builderRegistrationService) Run(ctx context.Context) {
 	if s.path != "" {
 		watcher, err := fsnotify.NewWatcher()
 		if err != nil {
-			log.Error(ctx, "Failed to create file watcher for builder registration overrides", err)
-			return
-		}
-		defer watcher.Close()
+			log.Warn(ctx, "Failed to create file watcher for builder registration overrides; file watching disabled", err)
+		} else {
+			dir := filepath.Dir(s.path)
+			if err := watcher.Add(dir); err != nil {
+				log.Warn(ctx, "Failed to watch directory for builder registration overrides; file watching disabled", err, z.Str("dir", dir))
+				watcher.Close()
+			} else {
+				defer watcher.Close()
 
-		dir := filepath.Dir(s.path)
-		if err := watcher.Add(dir); err != nil {
-			log.Error(ctx, "Failed to watch directory for builder registration overrides", err, z.Str("dir", dir))
-			return
+				fileEvents = watcher.Events
+				fileErrors = watcher.Errors
+			}
 		}
-
-		fileEvents = watcher.Events
-		fileErrors = watcher.Errors
 	}
 
 	// Optional API fetch timer (nil channel if obolClient == nil).
@@ -254,6 +254,10 @@ func (s *builderRegistrationService) Run(ctx context.Context) {
 		fetchCh = fetchTimer.C
 	}
 
+	if fileEvents == nil && fetchCh == nil {
+		return
+	}
+
 	baseName := filepath.Base(s.path)
 
 	for {

app/builderregistration_internal_test.go

@@ -218,6 +218,28 @@ func TestBuilderRegistrationService(t *testing.T) {
 		}
 	})
 
+	t.Run("missing directory returns without error", func(t *testing.T) {
+		// Path under a directory that does not exist. Watcher setup will fail,
+		// but with no API client configured, Run should return cleanly.
+		path := filepath.Join(t.TempDir(), "missing", "overrides.json")
+
+		svc, err := NewBuilderRegistrationService(ctx, path, eth2p0.Version{}, baseRegs, baseFeeRecipients, nil, nil)
+		require.NoError(t, err)
+
+		done := make(chan struct{})
+
+		go func() {
+			svc.Run(ctx)
+			close(done)
+		}()
+
+		select {
+		case <-done:
+		case <-time.After(time.Second):
+			t.Fatal("Run did not return when file watcher setup failed and no API client is configured")
+		}
+	})
+
 	t.Run("file watcher reloads on change", func(t *testing.T) {
 		dir := t.TempDir()
 		path := filepath.Join(dir, "overrides.json")