*: remove chain-split-halt (#4374)

* Comment out chain-split-halt (#4372)

* *: completely remove chain-split-halt (#4375)

* Completely remove chain-split-halt

* Remove unused attestationChecker function

Author: KaloyanTanev

app/app.go

@@ -664,7 +664,7 @@ func wireCoreWorkflow(ctx context.Context, life *lifecycle.Manager, conf Config,
 	// Consensus
 	consensusController, err := consensus.NewConsensusController(
 		ctx, eth2Cl, p2pNode, sender, peers, p2pKey,
-		deadlineFunc, gaterFunc, consensusDebugger, featureset.Enabled(featureset.ChainSplitHalt))
+		deadlineFunc, gaterFunc, consensusDebugger)
 	if err != nil {
 		return err
 	}

core/consensus/controller.go

@@ -40,11 +40,11 @@ type consensusController struct {
 // NewConsensusController creates a new consensus controller with the default consensus protocol.
 func NewConsensusController(ctx context.Context, eth2Cl eth2wrap.Client, p2pNode host.Host, sender *p2p.Sender,
 	peers []p2p.Peer, p2pKey *k1.PrivateKey, deadlineFunc core.DeadlineFunc,
-	gaterFunc core.DutyGaterFunc, debugger Debugger, compareAttestations bool,
+	gaterFunc core.DutyGaterFunc, debugger Debugger,
 ) (core.ConsensusController, error) {
 	qbftDeadliner := core.NewDeadliner(ctx, "consensus.qbft", deadlineFunc)
 
-	defaultConsensus, err := qbft.NewConsensus(ctx, eth2Cl, p2pNode, sender, peers, p2pKey, qbftDeadliner, gaterFunc, debugger.AddInstance, compareAttestations)
+	defaultConsensus, err := qbft.NewConsensus(ctx, eth2Cl, p2pNode, sender, peers, p2pKey, qbftDeadliner, gaterFunc, debugger.AddInstance)
 	if err != nil {
 		return nil, err
 	}

core/consensus/controller_test.go

@@ -66,7 +66,7 @@ func TestConsensusController(t *testing.T) {
 	bmock, err := beaconmock.New(ctx)
 	require.NoError(t, err)
 
-	controller, err := consensus.NewConsensusController(ctx, bmock, hosts[0], new(p2p.Sender), peers, p2pkeys[0], deadlineFunc, gaterFunc, debugger, false)
+	controller, err := consensus.NewConsensusController(ctx, bmock, hosts[0], new(p2p.Sender), peers, p2pkeys[0], deadlineFunc, gaterFunc, debugger)
 	require.NoError(t, err)
 	require.NotNil(t, controller)
 

core/consensus/qbft/msg.go

@@ -41,7 +41,7 @@ func newMsg(pbMsg *pbv1.QBFTMsg, justification []*pbv1.QBFTMsg, values map[[32]b
 		}
 	}
 
-	var justImpls []qbft.Msg[core.Duty, [32]byte, proto.Message]
+	var justImpls []qbft.Msg[core.Duty, [32]byte]
 
 	for _, j := range justification {
 		impl, err := newMsg(j, nil, values)
@@ -62,15 +62,15 @@ func newMsg(pbMsg *pbv1.QBFTMsg, justification []*pbv1.QBFTMsg, values map[[32]b
 	}, nil
 }
 
-// Msg wraps *pbv1.QBFTMsg and justifications and implements qbft.Msg[core.Duty, [32]byte, proto.Message].
+// Msg wraps *pbv1.QBFTMsg and justifications and implements qbft.Msg[core.Duty, [32]byte].
 type Msg struct {
 	msg               *pbv1.QBFTMsg
 	valueHash         [32]byte
 	preparedValueHash [32]byte
 	values            map[[32]byte]*anypb.Any
 
 	justificationProtos []*pbv1.QBFTMsg
-	justification       []qbft.Msg[core.Duty, [32]byte, proto.Message]
+	justification       []qbft.Msg[core.Duty, [32]byte]
 }
 
 func (m Msg) Type() qbft.MsgType {
@@ -118,7 +118,7 @@ func (m Msg) PreparedValue() [32]byte {
 	return m.preparedValueHash
 }
 
-func (m Msg) Justification() []qbft.Msg[core.Duty, [32]byte, proto.Message] {
+func (m Msg) Justification() []qbft.Msg[core.Duty, [32]byte] {
 	return m.justification
 }
 
@@ -227,4 +227,4 @@ func toHash32(val []byte) ([32]byte, bool) {
 	return resp, true
 }
 
-var _ qbft.Msg[core.Duty, [32]byte, proto.Message] = Msg{} // Interface assertion
+var _ qbft.Msg[core.Duty, [32]byte] = Msg{} // Interface assertion