Skip to content

Do not error if empty body on populateConsensusVersion #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KaloyanTanev merged 1 commit into from
Dec 15, 2025
Merged

Do not error if empty body on populateConsensusVersion #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions http/http.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,8 +370,8 @@ func populateConsensusVersion(res *httpResponse, resp *http.Response) error {
respConsensusVersions, exists := resp.Header["Eth-Consensus-Version"]
if !exists {
// No consensus version supplied in response; obtain it from the body if possible.
if res.contentType != ContentTypeJSON {
// Not present here either. Many responses do not provide this information, so assume
if res.contentType != ContentTypeJSON || res.body == nil || len(res.body) == 0 {
// Not present here either. Many responses do not provide this information, so assume
// this is one of them.
return nil
}
Expand Down
Loading