Skip to content

feat(dv-pod): add fetchFeeRecipientUpdates charon flag#272

Merged
nickh-obol merged 1 commit intomainfrom
nick/dv-pod-fetch-builder-registrations
May 7, 2026
Merged

feat(dv-pod): add fetchFeeRecipientUpdates charon flag#272
nickh-obol merged 1 commit intomainfrom
nick/dv-pod-fetch-builder-registrations

Conversation

@nickh-obol
Copy link
Copy Markdown
Contributor

@nickh-obol nickh-obol commented Apr 22, 2026

Summary

  • Adds a new charon.fetchFeeRecipientUpdates helm value (defaults to true) that renders the charon --fetch-feerecipient-updates CLI flag on the main charon container.
  • When enabled, charon polls the Obol API for signed fee recipient update messages that override the currently configured fee recipient. Charon's own default for this flag is false, so this chart default flips it on.
  • Flag is rendered unconditionally so users who set the value to false still get --fetch-feerecipient-updates=false passed explicitly.

Test plan

  • helm lint charts/dv-pod passes
  • helm template renders --fetch-feerecipient-updates=true by default
  • helm template --set charon.fetchFeeRecipientUpdates=false renders --fetch-feerecipient-updates=false
  • make docs regenerated charts/dv-pod/README.md cleanly
  • Deploy a dv-pod with the new default and confirm charon starts with the flag enabled

@nickh-obol nickh-obol requested a review from a team as a code owner April 22, 2026 18:50
@nickh-obol nickh-obol marked this pull request as draft April 22, 2026 18:58
@nickh-obol
Copy link
Copy Markdown
Contributor Author

nickh-obol commented Apr 22, 2026

Blocked on charon v1.10.0 stable release

Converting to draft — the --fetch-feerecipient-updates flag is not present in charon v1.9.x (the chart's currently-pinned default). It was introduced in v1.10.0-rc5.

Before this can merge:

  • charon v1.10.0 stable is released
  • Bump image.tag default in values.yaml to v1.10.0
  • Bump appVersion in Chart.yaml to 1.10.0
  • Re-run make docs

Without the charon bump, any default helm install would crash-loop on an unknown flag.

@nickh-obol nickh-obol marked this pull request as ready for review May 7, 2026 13:30
@nickh-obol nickh-obol merged commit 1f3d717 into main May 7, 2026
9 checks passed
@nickh-obol nickh-obol deleted the nick/dv-pod-fetch-builder-registrations branch May 7, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants