fix(dv-pod): mount ENR private key at non-nested path in DKG sidecar#278
Open
nickh-obol wants to merge 2 commits into
Open
fix(dv-pod): mount ENR private key at non-nested path in DKG sidecar#278nickh-obol wants to merge 2 commits into
nickh-obol wants to merge 2 commits into
Conversation
Signed-off-by: nickh-obol <nick_h@obol.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The dkg-sidecar init container mounts the `charon-enr-private-key` secret as a subPath file at `/charon-data/charon-enr-private-key`, nested inside the `/charon-data` PVC mount. On k3d / Docker Desktop on macOS this triggers a runc `outside of rootfs` error at pod creation, blocking deployment entirely.
The same secret is already mounted non-nested at `/enr-from-job`, so the nested mount is redundant. This PR removes it and points `CHARON_PRIVATE_KEY_FILE` at the existing path. The dkg-sidecar honors the env var (source), so no sidecar code change is required.
Changes
The cluster-lock configMap mount under `/charon-data` was left as-is; it can be addressed separately if needed.
Test plan
Static
Live hoodi cluster (linux, local-path SC)
Upgraded all 4 `my-dv-pod-{0..3}` releases in the `dv-pod` namespace to `0.18.2` and brought the two scaled-down replicas back up.
macOS / k3d
Related
PR #163 addresses a similar but distinct issue (`cluster-definition.json` write under `/charon-data` causing `EACCES` on `local-path`). Both stem from piling files under the `/charon-data` PVC. Scoping this fix narrowly to the ENR mount; #163 can be picked up separately.