fix(dv-pod): default fetchFeeRecipientUpdates to true when nil#283
Merged
Conversation
aly-obol
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
helm upgrade --reuse-valuesfrom a chart predating thecharon.fetchFeeRecipientUpdateskey (e.g.dv-pod-0.17.0/0.18.x) carries forward the previous release's effective values without merging the upgraded chart's newvalues.yamldefaults. The template then resolved.Values.charon.fetchFeeRecipientUpdatesto nil and rendered--fetch-feerecipient-updates=(empty), and charon refused to start withinvalid argument "" for "--fetch-feerecipient-updates" flag: strconv.ParseBool: parsing "": invalid syntax.truewhen the value is nil while preserving an explicittrueorfalsefrom the user. Keeps PR feat(dv-pod): add fetchFeeRecipientUpdates charon flag #272's "always render the flag" intent so charon's ownfalsedefault never silently takes over.--reuse-values(the long-standing default many docs and habits assume) without having to know about--reset-then-reuse-values.Test plan
helm template charts/dv-pod --set charon.fetchFeeRecipientUpdates=null→ renders--fetch-feerecipient-updates=truehelm template charts/dv-pod --set charon.fetchFeeRecipientUpdates=true→ renders--fetch-feerecipient-updates=truehelm template charts/dv-pod --set charon.fetchFeeRecipientUpdates=false→ renders--fetch-feerecipient-updates=falsehelm template charts/dv-pod(default) → renders--fetch-feerecipient-updates=truehelm lint charts/dv-podpassesmake docsproduces no diff (template-only change)Auto Version Bumpworkflow ticks chart0.19.0→0.19.1(patch — appVersion unchanged)