Adding fallback bn envs, unclear will the empty string cause upset#134
Merged
Conversation
DiogoSantoss
approved these changes
Apr 1, 2025
KaloyanTanev
reviewed
Apr 2, 2025
Co-authored-by: Kaloyan Tanev <24719519+KaloyanTanev@users.noreply.github.com> Signed-off-by: Oisín Kyne <4981644+OisinKyne@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds env vars for specifying a remote fallback BN with HTTP basic auth protection. The aim is to make it easy to update your primary BN without a long down time.
This PR needs testing as to whether the presence ofTested, seems fine to go with an empty string it doesn't complain.--fallback-beacon-node-endpoints ""will cause undue errors or warnings in charon, we may need to decide on an adjusted approach if so.