Introduce multi-client options#149
Conversation
OisinKyne
left a comment
OisinKyne
left a comment
There was a problem hiding this comment.
Not allowed approve cause its my PR 😅
Really elegant solution :D has a conflict with main now, and ejector needs to be re-enabled, but I'm down to give this a merge and test on hoodi once we have confidence in grandine (maybe we want to explain the other ones aren't ready yet in case people turn them on, i'm not so worried of that though)
KaloyanTanev
force-pushed
the
oisin/profiles
branch
from
d1827da to
f827ffa
Compare
|
@aly-obol not really. End of life will be officially end of September, however, I doubt anyone is using it atm. I'd rather delete it in separate PR though. |
| EL=el-nethermind | ||
| # Consensus layer client to be used in a DV setup. | ||
| # Available options: lighthouse, grandine. | ||
| CL=cl-lighthouse | ||
| # Validator client to be used in a DV setup. | ||
| # Available options: lodestar, nimbus. | ||
| VC=vc-lodestar | ||
| # MEV client to be used in a DV setup. | ||
| # Available options: mevboost, commitboost. | ||
| MEV=mev-mevboost |
There was a problem hiding this comment.
Just looking at this now. I think we should give the explicit lines to comment/uncomment, people might not notice that they need to keep the cl-|vc-|mev- when switching from cl to cl the existing way
| EL=el-nethermind | |
| # Consensus layer client to be used in a DV setup. | |
| # Available options: lighthouse, grandine. | |
| CL=cl-lighthouse | |
| # Validator client to be used in a DV setup. | |
| # Available options: lodestar, nimbus. | |
| VC=vc-lodestar | |
| # MEV client to be used in a DV setup. | |
| # Available options: mevboost, commitboost. | |
| MEV=mev-mevboost | |
| EL=el-nethermind | |
| # Consensus layer client to be used in a DV setup. Uncomment only one. | |
| # Available options: lighthouse, grandine. | |
| CL=cl-lighthouse | |
| #CL=cl-grandine | |
| # Validator client to be used in a DV setup. Uncomment only one. | |
| # Available options: lodestar, nimbus. | |
| VC=vc-lodestar | |
| #VC=vc-nimbus | |
| # MEV client to be used in a DV setup. Uncomment only one. | |
| # Available options: mevboost, commitboost. | |
| MEV=mev-mevboost | |
| #MEV=mev-commitboost |
KaloyanTanev
force-pushed
the
oisin/profiles
branch
from
5dc8560 to
6672329
Compare
4 participants
Problem to be solved
We want to make it easy to change client types
Proposed solution
Use docker profiles to enable and disable different client choices.
This PR, when merged requires users to add
COMPOSE_PROFILES=el_nethermind,cl_lighthouse,dv_charon,vc_lodestar,mev_mevboostto their .env file for their stack to remain unchanged. Work needs to be completed on this PR to introduce the alternate clients commented out in this pr so far.