Skip to content

Add RPC API endpoint env #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KaloyanTanev merged 3 commits into from
Aug 13, 2025
+10 −0
Merged

Add RPC API endpoint env #156

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0288b1d
add eth1 flag
DiogoSantoss Aug 12, 2025
929e3e4
fix eth1 flag
DiogoSantoss Aug 13, 2025
f6ecc3b
fix rpc flag
DiogoSantoss Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ services:
- CHARON_LOKI_ADDRESSES=${CHARON_LOKI_ADDRESSES:-http://loki:3100/loki/api/v1/push}
- CHARON_LOKI_SERVICE=charon
- CHARON_NICKNAME=${CHARON_NICKNAME:-}
- CHARON_EXECUTION_RPC_API_ENDPOINT=${CHARON_EXECUTION_RPC_API_ENDPOINT:-}
Copy link
Copy Markdown

@OisinKyne OisinKyne Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we should default to the EL right here in the stack, currently that's `

Suggested change
- CHARON_EXECUTION_RPC_API_ENDPOINT=${CHARON_EXECUTION_RPC_API_ENDPOINT:-}
- CHARON_EXECUTION_RPC_API_ENDPOINT=${CHARON_EXECUTION_RPC_API_ENDPOINT:-"http://nethermind:8545}

also, the flag is execution-client-rpc-endpoint if the docs are right, so shouldn't it be CHARON_EXECUTION_CLIENT_RPC_ENDPOINT ?

Copy link
Copy Markdown

@OisinKyne OisinKyne Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, Kalo's #149 changes this to el-nethermind so we need to change this or kalo's pr should change it after this goes in

Copy link
Copy Markdown
Author

@DiogoSantoss DiogoSantoss Aug 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right, I looked at the (eth1) PR description but it had the flag outdated

Copy link
Copy Markdown
Author

@DiogoSantoss DiogoSantoss Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to push it with nethermind and then after kalo's PR rebase we change it to el-nethermind

ports:
- ${CHARON_PORT_P2P_TCP:-3610}:${CHARON_PORT_P2P_TCP:-3610}/tcp # P2P TCP libp2p
networks: [dvnode]
Expand Down