Skip to content

Commit 8fb1553

Browse files
JeanDaniel Bussybussyjd
andauthored
chore(controller): repin serviceoffer-controller to b39bcaa for rc11 (#592)
Bumps the embedded serviceoffer-controller image pin from the rc9 build (503016b) to b39bcaa (post-rc10 main). b39bcaa is a descendant of 503016b, so it retains the Secret-create-only reconciler fix (the per-agent provisioning 403 guard), and additionally ships PR #590's actionable pending-registration status message (awaitingExternalRegistrationMessage). Even rc10 still ran the rc9 controller image, so this also catches the deployed controller up to current main (incl. purchase.go reconcile fixes). Updates the two provenance tripwires that assert the pin (TestEmbeddedImages_X402ControllerAndBuyerUseFixPins and TestServiceOfferControllerImage_CarriesSecretCreateOnlyFix). New pin: ghcr.io/obolnetwork/serviceoffer-controller:b39bcaa@sha256:f5afbba041f83c52c1d48c61db443138da76a12afed0bd29ba719984fc73b189 Prerequisite for cutting v0.10.0-rc11. go build + internal/embed tests green. Co-authored-by: bussyjd <bussyjd@users.noreply.github.com>
1 parent bc9edcb commit 8fb1553

3 files changed

Lines changed: 10 additions & 8 deletions

File tree

internal/embed/embed_crd_test.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -797,7 +797,8 @@ func TestX402VerifierImage_CarriesAgentAuthFix(t *testing.T) {
797797
// treats Secret as create-only (isCreateOnlyKind). The image MUST therefore be
798798
// built from source that has that behaviour — the prior f5d94fc side-branch pin
799799
// did not, so the deployed binary Updated the per-agent Secrets on re-reconcile
800-
// and 403'd. 503016b (rc9 commit 503016bf, image 0.10.0-rc9) carries the fix.
800+
// and 403'd. b39bcaa (post-rc10 main) carries the fix, and also ships PR #590's
801+
// actionable pending-registration status message.
801802
// Bumping this pin requires a conscious, documented change here so a future
802803
// downgrade can't silently re-ship the bug.
803804
func TestServiceOfferControllerImage_CarriesSecretCreateOnlyFix(t *testing.T) {
@@ -806,7 +807,7 @@ func TestServiceOfferControllerImage_CarriesSecretCreateOnlyFix(t *testing.T) {
806807
t.Fatalf("ReadInfrastructureFile: %v", err)
807808
}
808809

809-
const ref = "ghcr.io/obolnetwork/serviceoffer-controller:503016b@sha256:bec62ea04842caf62980b529a89f5d553987a106c3167eb45209a8b278121957"
810+
const ref = "ghcr.io/obolnetwork/serviceoffer-controller:b39bcaa@sha256:f5afbba041f83c52c1d48c61db443138da76a12afed0bd29ba719984fc73b189"
810811
if !strings.Contains(string(data), "image: "+ref) {
811812
t.Fatalf("serviceoffer-controller image must carry the Secret-create-only reconciler fix "+
812813
"(else per-agent provisioning 403s under the no-update/patch Secret RBAC): %s", ref)

internal/embed/embed_image_pin_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -230,12 +230,12 @@ func TestEmbeddedImages_X402ControllerAndBuyerUseFixPins(t *testing.T) {
230230
ref string
231231
}{
232232
{
233-
// Repinned off the f5d94fc side-branch build (which predated the
234-
// Secret-create-only reconciler change) to the rc9 release image
235-
// (commit 503016b, image 0.10.0-rc9).
233+
// Repinned off the rc9 image (503016b) to b39bcaa (post-rc10 main):
234+
// still carries the Secret-create-only reconciler change, and adds
235+
// PR #590's actionable pending-registration status message.
236236
// See TestServiceOfferControllerImage_CarriesSecretCreateOnlyFix.
237237
file: "base/templates/x402.yaml",
238-
ref: "ghcr.io/obolnetwork/serviceoffer-controller:503016b@sha256:bec62ea04842caf62980b529a89f5d553987a106c3167eb45209a8b278121957",
238+
ref: "ghcr.io/obolnetwork/serviceoffer-controller:b39bcaa@sha256:f5afbba041f83c52c1d48c61db443138da76a12afed0bd29ba719984fc73b189",
239239
},
240240
{
241241
file: "base/templates/llm.yaml",

internal/embed/infrastructure/base/templates/x402.yaml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -349,9 +349,10 @@ spec:
349349
# per-agent hermes-api-server / remote-signer-keystore Secrets on
350350
# re-reconcile 403s and per-agent provisioning never converges. The
351351
# prior pin (f5d94fc) predated that source change and shipped the
352-
# bug; 503016b (rc9 commit 503016bf, image 0.10.0-rc9) carries it.
352+
# bug; b39bcaa (post-rc10 main) carries it, and also ships PR #590's
353+
# actionable pending-registration status message.
353354
# See TestServiceOfferControllerImage_CarriesSecretCreateOnlyFix.
354-
image: ghcr.io/obolnetwork/serviceoffer-controller:503016b@sha256:bec62ea04842caf62980b529a89f5d553987a106c3167eb45209a8b278121957
355+
image: ghcr.io/obolnetwork/serviceoffer-controller:b39bcaa@sha256:f5afbba041f83c52c1d48c61db443138da76a12afed0bd29ba719984fc73b189
355356
imagePullPolicy: IfNotPresent
356357
securityContext:
357358
allowPrivilegeEscalation: false

0 commit comments

Comments
 (0)